Repository navigation
ADR-011 consent + per-site usage-data setting; Connect step fixes - #25
Merged
Merged
Conversation
…ect step fixes ADR-011 (telemetry: one grant, given by the Terms, refused per site): - the consent step asks about usage data only on an UNCONNECTED FREE plugin, once per site; licensed/connected accounts are never asked (their Terms are the grant), whatever an older server block says - one-tier wording (telemetry v2); drop the paid 'basics already shared' line; heading says 'One optional thing' when only one is asked - new onboarding/site-telemetry.php: 'Don't send usage data from this site' — one site answer in the consent outbox, delivered like any answer (server stores it as the site's exclusion); shown in Tangible Home's 'This site' block, render_site_telemetry_setting() for plugins Connect: - step id 'connect' -> 'tangible_connect' (label 'tangible.one'): SearchSync's backend step is also 'connect', which fatals resolve_plan - pending (approved but unverified) is its own screen: says why (local dev site / unreachable REST API), 'Check again' re-confirms, Skip moves on without dropping the pending connection - app/API URLs default from TANGIBLE_CLOUD_URL when the Connect constants are unset, so a staging-pointed site no longer Connects to prod Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JAdkRhF6yVmWWZBdUgV8Si
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Framework half of ADR-011 (server half: TangibleInc/tangible-one#299), plus the Connect bugs found while screenshotting the onboarder.
ADR-011
ask.telemetry v2), "basics already shared under your licence" line removed, heading reads "One optional thing" when only one question is asked.onboarding/site-telemetry.php): one site answer in the existing consent outbox, delivered like any answer — the server (#299) stores it as the site's exclusion. Shown in Tangible Home's This site block; plugins can callrender_site_telemetry_setting()in their own settings.Connect
connect→tangible_connect(rail label "tangible.one"). SearchSync's own backend step isconnect, so free SearchSync fataled with Onboarding step id "connect" registered twice.TANGIBLE_CONNECT_APP_URL/TANGIBLE_CLOUD_APIare unset they now derive fromTANGIBLE_CLOUD_URL(api.staging.tangible.one/api/edd→ appstaging.tangible.one). Before, a staging-pointed site sent Connect to prod.Tests: wp-env PHPUnit 113 tests / 309 assertions OK. New: coexists with a plugin step named
connect; pending render + Check again; only unconnected free is asked; site setting is one answer; URL derivation.Follow-up for plugin repos: vendored copies (e.g. SearchSync) need the framework bump; plugins should add
render_site_telemetry_setting()to their settings page.🤖 Generated with Claude Code
https://claude.ai/code/session_01JAdkRhF6yVmWWZBdUgV8Si