Skip to content

fix(partners): remove Cloudflare reserved placement - #1291

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/remove-cloudflare-priority
Sep 23, 2026
Merged

tannerlinsley merged 1 commit into
mainfrom
taren/remove-cloudflare-priority

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Cloudflare no longer has exclusive placement. Remove the reserved placement rules so it follows the same tier ordering and session rotation as every other partner, including deployment buttons and mixed-category lists.

Remove the outdated placement policy and extend the hosting rotation regression test to cover Cloudflare.

Validation: pnpm test passed, including TypeScript, lint, and 525 unit tests (3 skipped).

Summary by CodeRabbit

  • Changes
    • Partner placement now follows tier-based ordering, seeded rotation, or legacy comparison. Reserved partners are no longer moved ahead of other partners in the same category.
  • Documentation
    • Updated partner-placement guidance to remove references to reserved placement rules.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 696bf022-8178-46e3-a3a7-ae45a9233c83

📥 Commits

Reviewing files that changed from the base of the PR and between 4a9ef75 and 1c9f4f6.

📒 Files selected for processing (3)
  • docs/partner-placement.md
  • src/utils/partner-placement.ts
  • tests/application-starter-partners.test.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The placement utility no longer gives reserved partners priority over other partners. The documentation no longer describes reserved placement rules, and the hosting-rotation test now includes Cloudflare.

Changes

Partner Placement Ordering

Layer / File(s) Summary
Remove reserved partner ordering
src/utils/partner-placement.ts, tests/application-starter-partners.test.ts, docs/partner-placement.md
The placement utility removes reserved-partner ordering and returns the sorted partners directly. The hosting-rotation test includes Cloudflare, and the documentation removes its reserved-rule descriptions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 1c9f4

Cloudflare no longer has a reserved first position in deployment and hosting lists. It now follows the same tier ordering and session rotation as other partners, as intended. The documentation and the hosting-rotation test were updated to match, and no remaining defect was found. The change is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing Cloudflare's reserved partner placement.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tannerlinsley
tannerlinsley merged commit 385e0e4 into main Sep 23, 2026
7 checks passed
@tannerlinsley
tannerlinsley deleted the taren/remove-cloudflare-priority branch September 23, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant