Skip to content

[InlineEdit]: New TEDI-Ready component #199

Open

Description

@airikej

https://github.com/TEHIK-EE/tedi-design-system/issues/193
Figma

  • no API changes
  • Move to TEDI-Ready
  • Add unit test
  • improve WCAG for toggle button
  • improve props descriptions
  • add documentation to ZeroHeight
Name Required/Optional Description Type Possible Values Default
className Optional Classname for the button/displayed content string Any valid CSS class name
content Required Content displayed when the field is hidden. React.ReactNode Any valid React node
fieldType Required Specifies the type of hidden field. 'textfield' | 'select' | 'datetime' 'textfield', 'select', 'datetime'
fieldOptions Required Configuration options for the specified field type. TextFieldProps (for textfield), SelectProps (for select), DateTimePickerProps (for datetime) Based on the fieldType

Activity

  1. converted this from a draft issue on Jan 22, 2025
  2. moved this from Backlog to Waiting feedback in TEDI development (React, Angular)on Jan 22, 2025
  3. kasparsuvi1 commented on Jan 24, 2025

    @kasparsuvi1
    Contributor

    This is legacy component from STAR project, i dont think it's needed to be moved to TEDI. It's not with very good UX and shouldn't be recommended from Tedi probally. Im pretty sure nobody else is using it also. (For legacy support we can keep in community?)

  4. airikej commented on Jan 24, 2025

    @airikej
    ContributorAuthor

    If that's the case we could add legacy tag to it and keep it in Community. Only problem is currently it's designed in Figma. What is your opinion on that @karolin-kivisikk would designers miss this component if we removed it? Or are there good reasons to keep it?

  5. karolin-kivisikk commented on Jan 24, 2025

    @karolin-kivisikk

    Actually, when I went through the components then someone at the Design meeting said that it's needed but I don't remember which project was it. It was some newer project I think who wanted to use it inside of a table.

    From UX perspective yes it's not a good practice but if it's used in some inner projects only for officers then it's fine I guess, but not a preferred solution of course.
    But true if the usage is so low that maybe it's best to leave it in the Community? I have to think what to do with the Figma design then, it's published some time ago already.

  6. tobre6 commented on Jan 24, 2025

    @tobre6
    Contributor

    I can see some business value, but name is misleading.

  7. airikej commented on Feb 26, 2025

    @airikej
    ContributorAuthor

    Low priority

  8. moved this from Waiting feedback to Backlog in TEDI development (React, Angular)on Feb 26, 2025
  9. changed the title [-]Hidden field[/-] [+][HiddenField]: New TEDI-Ready component[/+] on Dec 18, 2025
  10. 56 remaining items

  11. intermetric commented on Oct 23, 2026

    @intermetric
    Contributor

    @karolin-kivisikk Mõlema teostuse muudatuste kokkuvõte ja Storybooki lingid on Angulari issue kommentaaris.

  12. moved this from Code review to Design review in Developmenton Oct 23, 2026
  13. karolin-kivisikk commented on Oct 27, 2026

    @karolin-kivisikk
  14. moved this from Design review to In Progress in Developmenton Oct 28, 2026
  15. moved this from In Progress to Design review in Developmenton Oct 30, 2026
  16. intermetric commented on Oct 30, 2026

    @intermetric
    Contributor

    @karolin-kivisikk Reacti pool on samuti uueks ülevaatuseks valmis. Paranduste kokkuvõte.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

tedi-readyTEDI-Ready component issue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions