Repository navigation
test(chromatic): consolidate simple component snapshots #825 - #829
Open
mart-sessman wants to merge 1 commit into
Open
mart-sessman wants to merge 1 commit into
mart-sessman wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
mart-sessman
temporarily deployed
to
github-pages
November 2, 2026 14:33 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
mart-sessman
requested review from
intermetric and
ly-tempel-bitweb
and removed request for
ly-tempel-bitweb
November 2, 2026 14:34
♿ Accessibility — ✅ no blocking violationsNo accessibility violations in the components changed by this PR. 🔕 Known issues — 20 stories marked
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
intermetric
reviewed
Nov 3, 2026
| }, | ||
| styles: [".icon-vt-inherit { font-size: 60px; }"], | ||
| template: ` | ||
| <tedi-row [cols]="1" [gapY]="5"> |
Contributor
There was a problem hiding this comment.
moduleMetadata is missing RowComponent and ColComponent, so the VisualTest grid doesn't render.
| render: () => ({ | ||
| props: { ...ITEM_STATES_PROPS, separator: false }, | ||
| template: ` | ||
| <tedi-row [cols]="1" [gapY]="4"> |
Contributor
There was a problem hiding this comment.
Same as Icon: RowComponent and ColComponent aren't imported, so this layout renders without the grid.
intermetric
reviewed
Nov 3, 2026
| * `md`, full trail from `md` up — resize the viewport to see it switch. | ||
| */ | ||
| export const ResponsiveVariant: Story = { | ||
| parameters: { chromatic: { disableSnapshot: false } }, |
Contributor
There was a problem hiding this comment.
Non-blocking: same as on the React PR, the responsive stories kept as separate snapshots (this one, Pagination ResponsiveAlign/ResponsiveVisibility, Responsive etc.) have no viewport, so they're only captured at desktop width. Either add viewports: [375, 1280], or move them into VisualTest.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #825
Each of the 41 simple components in #825 now has one hidden
VisualTeststory holding its visual variants, and the meta turns Chromatic snapshots off for the docs stories. Docs stories render as before. Snapshotted stories go from 622 to 381.Changes
VisualTeststory in each file, tagged!devand!autodocs, withchromatic.disableSnapshot: false. Every block has a bold label so a diff is easy to place.MobileDropdownInitiallyOpenResponsiveResponsiveMaxLengthResponsiveEndResponsiveResponsiveandAnimatedResponsiveVariantOverflowBehaviorStickyInLayout,CollapsibleandCollapsibleHideOnScrollResponsiveAlignandResponsiveVisibilityVerticalTree(it sets its state with a timer)AccordionBehavior,HashDeepLinkingandSemanticHeadingsClearButtonOnInteractionAccessibilityClickToNavigateandExternalNavigationnames and landmark labels are uniquebg bg-primarypanel instead of the global brand backgroundstories.mddocuments the pattern and adds a checklist line: a new visual story on a component withVisualTestmust also add its variant there.Checked locally
VisualTeststories. The only failures are in untouched community stories.VisualTeststory renders in Playwright with no console errors and no duplicate ids.The first Chromatic build after merge will show the new
VisualTestsnapshots as additions; accepting them sets the new baseline.React counterpart: TEDI-Design-System/react#1050