Skip to content

[Calendar]: Scaling inside modal #505

Closed

Description

@airikej

Problem

Currently the calendar inside date fields modal picker doesnt scale but stays in its 315px width when modal is larger. Design wants it to be configurable and allow scaling

Solution

Examples and information

Project

DoD

  • The component is developed using best practices, conventions, and modern frontend trends
  • The component follows BEM naming conventions (if applicable)
  • The component implementation matches the Figma design, including all defined states and interactions
  • The component supports responsiveness and scales across breakpoints (if applicable)
  • The component does not introduce runtime errors or warnings
  • Linter passes
  • Component has export if needed
  • The component has unit tests with at least 80% code coverage
  • CodeCov passes minimum coverage threshold
  • The component has passed code review
  • The component has passed Chromatic visual review
  • Storybook stories are created:
    • Cover all Figma variations
    • Include edge cases, empty/error states
  • Component’s API (props, slots, events) is documented
  • ZeroHeight is updated with design/development guidelines
  • External dependencies used in the component are documented in Confluence with rationale.
  • Semantic commit format is used (for semantic-release)
  • External libraries comply with validated open source licenses
  • Component is versioned correctly and ready for release if required
  • Update statuses page in Zeroheight

Activity

  1. moved this to Backlog in Developmenton Jun 30, 2026
  2. mart-sessman commented on Jul 1, 2026

    @mart-sessman
    Contributor

    @airikej got more info on this? react already has this behavior? its described in Figma? How should it scale exactly?

  3. airikej commented on Jul 1, 2026

    @airikej
    ContributorAuthor

    @mart-sessman currently in full width modal in mobile the calendar sits inside modal like this:

    Image

    but design wants the calendar to fill the width of the modal like side to side e.g similarly to this:

    Image
  4. intermetric commented on Sep 30, 2026

    @intermetric
    Contributor

    @karolin-kivisikk Palun vaata üle DateField'i Mobile Modal näide. Teise välja kalender täidab modaali laiuse. Selle saab sisse lülitada sisendiga [calendarFullWidth]="true". Kas see lahendus tundub sobiv?

  5. mart-sessman commented on Oct 7, 2026

    @mart-sessman
    Contributor

    Vaatasin reacti lahendust, seal skaleerub kalender mõlemas suunas proportsionaalselt ja ka nuppude suurused muutuvad:
    https://storybook.tedi.ee/react/main/?path=/story/tedi-ready-content-calendar--full-width-sizes

  6. 15 remaining items

  7. intermetric commented on Oct 28, 2026

    @intermetric
    Contributor

    @karolin-kivisikk Scroll parandatud. See tekkis mobiilivaates pikemate kuunimedega, kui päis enam kalendri laiusesse ei mahtunud. Nüüd OK.

    Ma arvan, et kogu Storybooki näidete uuendamise võiks jätta eraldi taskiks, et see PR jääks skaleerumise teema piiresse. Kui uus Figma frame on valmis, tee palun selle kohta uus issue.

  8. moved this from In Progress to Design review in Developmenton Oct 28, 2026
  9. karolin-kivisikk commented on Oct 29, 2026

    @karolin-kivisikk

    24. @karolin-kivisikk Scroll parandatud. See tekkis mobiilivaates pikemate kuunimedega, kui päis enam kalendri laiusesse ei mahtunud. Nüüd OK.
    Ma arvan, et kogu Storybooki näidete uuendamise võiks jätta eraldi taskiks, et see PR jääks skaleerumise teema piiresse. Kui uus Figma frame on valmis, tee palun selle kohta uus issue.

    Kas figma frame-idele viimine peaks iga komponendi kohta olema eraldi või saame kuidagi rohkem korraga neid ka viia? Kuna see komponendi enda arendust ei mõjuta oleks kergem teha disain reviewd kui ka nö tarnida kui oleks korraga tehtud?

  10. intermetric commented on Nov 2, 2026

    @intermetric
    Contributor

    @karolin-kivisikk

    Kas figma frame-idele viimine peaks iga komponendi kohta olema eraldi või saame kuidagi rohkem korraga neid ka viia? Kuna see komponendi enda arendust ei mõjuta oleks kergem teha disain reviewd kui ka nö tarnida kui oleks korraga tehtud?

    Ma ei näe põhjust, miks ei võiks korraga suuremat kogust komponente migreerida, aga ühes issue's võiks pigem olla mõistlik kogus, näiteks kategooria kaupa (Form, Overlay jne)? Siis jääb nii arendus kui ka design review hallatavaks ja üks lahtine küsimus ei hoia kõiki teisi kinni.

  11. moved this from Design review to Code review in Developmenton Nov 2, 2026
  12. moved this from Code review to Done in Developmenton Nov 5, 2026
  13. added a commit that references this issue on Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

tedi-readyTEDI-Ready component issue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions