Repository navigation
fix: restore RFC 6532 internationalized mailbox parsing - #178
Merged
Merged
Conversation
The forensic scanner introduced for issue #175 restricted atoms to ASCII, dropping valid UTF-8 local parts and domains in 4.7.0. Extend atoms to Unicode scalar values and preserve mailbox identity across byte decoding and whitespace handling. Retain invalid UTF-8 as explicit defect evidence, including group labels and comments, without losing valid neighbouring mailboxes. Add regression coverage for issue #177 and document the recovery behavior. Reviewed RFC 5322 sections 3.2-3.4, 4 and 5; RFC 6532 sections 3.1-3.2 and 4; RFC 3629 scalar restrictions; RFC 6854 and applicable errata. Verified conforming UTF-8, obsolete routes, malformed inputs and recovery metadata. The pre-existing isolated-surrogate failure in parse_from_string remains outside this change. Validation: 951 tests pass on Python 3.13 and 3.14; pre-commit and Pyright pass. Independent security review found no remaining introduced High/Medium findings after malformed-byte fuzzing and bounded scaling probes.
|
coverage: 99.765% (-0.05%) from 99.818% — bugfix/issue_#177 into develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forensic scanner introduced for issue #175 restricted atoms to ASCII, dropping valid UTF-8 local parts and domains in 4.7.0. Extend atoms to Unicode scalar values and preserve mailbox identity across byte decoding and whitespace handling.
Retain invalid UTF-8 as explicit defect evidence, including group labels and comments, without losing valid neighbouring mailboxes. Add regression coverage for issue #177 and document the recovery behavior.
Reviewed RFC 5322 sections 3.2-3.4, 4 and 5; RFC 6532 sections 3.1-3.2 and 4; RFC 3629 scalar restrictions; RFC 6854 and applicable errata. Verified conforming UTF-8, obsolete routes, malformed inputs and recovery metadata. The pre-existing isolated-surrogate failure in parse_from_string remains outside this change.
Validation: 951 tests pass on Python 3.13 and 3.14; pre-commit and Pyright pass. Independent security review found no remaining introduced High/Medium findings after malformed-byte fuzzing and bounded scaling probes.
@rosscaleca can you test this branch? Maybe you have a lot of data that can be used to find other bugs and/or regresssions.