Repository navigation
test(cvrp): run the union lowering test with its union fixture - #192
Merged
Merged
Conversation
`compiled_cvrp_union_selector_lowers_every_node_once` solved the shared CVRP domain with that domain's embedded k-opt construction config, so the benchmark selector union it guards was never compiled; the fixture holding the union was referenced by nothing, and the test passed with the `rebase_graph` edge shift reverted. The domain now takes its solver TOML from a field through its `config` callback; the k-opt test keeps the k-opt fixture and the union test solves with the union fixture, bounded by 50 steps instead of 5 seconds, and asserts that local search evaluated moves. Reverting the edge shift now fails it. Closes #190.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190. Base
main@86cf918f, one commit32f7fe2e.Mutation check (reverting the
Limited.selectoredge shift inrebase_graph, the e958244 fix): onmainthe test still passes; with this commit it fails with "each compiled selector node lowers exactly once".Gate on
32f7fe2e: EXIT 0, 1537 passed, 0 failed, 66 result lines.