Repository navigation
fix(acceptor)!: reject acceptor values that cannot do what they say - #186
Merged
Merged
Conversation
`step_counting_hill_climbing.step_count_limit = 0` was accepted and left the acceptor accepting only strictly improving moves, because no step is ever within a limit of zero. It is now rejected with a configuration error naming the field. BREAKING CHANGE: `step_counting_hill_climbing.step_count_limit = 0` is a configuration error.
`great_deluge.water_level_increase_ratio` accepted zero, negative, NaN and infinite values, none of which raises the water level as documented. The ratio must now be finite and greater than 0. BREAKING CHANGE: a non-positive or non-finite `great_deluge.water_level_increase_ratio` is a configuration error.
…emperatures `simulated_annealing.calibration` was silently ignored when `level_temperatures` was also set. Setting both is now a configuration error naming `calibration`. Closes #177. BREAKING CHANGE: `simulated_annealing` with both `calibration` and `level_temperatures` is a configuration error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #177. Base
main@4c86a99a, three commits:0f1d83d8reject a zero step-counting step_count_limit20311034reject a great-deluge ratio that does not rise601f8968reject simulated-annealing calibration beside level_temperaturesEach commit passed fmt, clippy -D warnings, config rustdoc -D warnings, and the builder and config tests on its own (74, 75, 76 passed; 0 failed). Gate on
601f8968(fmt, clippy, doc-names file-length facade-reachability public-api deps, rustdoc, examples, workspace all-feature tests, doctests): EXIT 0, 1527 passed, 0 failed, 65 result lines.