Repository navigation
fix(vnd)!: honour score_tie_break among equally scored best moves - #184
Merged
Merged
Conversation
Variable neighborhood descent accepted `score_tie_break` and dropped it in lowering; it always kept the first of several equally scored best improving moves. Lowering now passes the value to the VND runner, which keeps the first tie under `first` and selects among ties by the foragers' seeded reservoir selection, from the step's seed, under `random`. Closes #175. BREAKING CHANGE: VND phases now use `score_tie_break`, whose default is `random`, so a VND phase without `score_tie_break = "first"` may apply a different one of several equally scored best improving moves than before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #175. Base
main@fb8a0e0e, one commite28376fa.Gate on
e28376fa(fmt, clippy -D warnings, doc-names file-length facade-reachability public-api deps, rustdoc -D warnings, examples, workspace all-feature tests, doctests): EXIT 0, 1524 passed, 0 failed, 65 result lines. Mutation check: a VND that never replaces an equally scored best failsrandom_picks_among_tied_moves_reproducibly.