Repository navigation
fix(check): accept entity-scoped value_range_provider fields - #7
Merged
Merged
Conversation
solverforge check rejected a scalar planning variable whose value_range_provider names a Vec<usize> field on the same entity, although SolverForge's planning_variable contract gives that form each entity its own legal domain. Valid models such as the Furnace use case failed check. Domain parsing now records each entity's Vec<usize> fields, and check accepts a provider that names a solution fact collection or one of those fields. A provider that names neither still fails, and the message now says what it must be. Closes #6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6. Local gate: fmt, clippy, unit, scaffold, runtime, MCP, install-skill, skill references and browser e2e all passed; the new test fails when the entity-field check is removed.