Repository navigation
fix(constraints): list constraints from the constraint-modules manifest - #12
Merged
Merged
Conversation
list_constraints treated every .rs file in src/constraints except mod.rs and assemble.rs as a constraint, so helper modules such as shared.rs, support.rs or a tests.rs module showed up as constraints in solverforge.app.toml, the generated ui-model.json, `solverforge info` and destroy's dependent-constraint hints. The constraint ids are now the modules declared in the constraint-modules block of src/constraints/mod.rs, validated the same way check and the model contract read them; a malformed manifest is reported instead of guessed around, and destroy matches dependents against that list. The file-name predicate is gone. The destroy fixtures declare the constraints they write, as generate constraint does. Closes #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11. Local gate on the branch tip: fmt, clippy, unit (238), scaffold, runtime, MCP, install-skill, skill references and browser e2e all passed. The new list_constraints test fails when the file-name scan is restored.