Repository navigation
fix(capacitors): validate maxPacketLength_ input instead of stale state - #438
Open
HusseinAdeiza wants to merge 1 commit into
Open
HusseinAdeiza wants to merge 1 commit into
HusseinAdeiza wants to merge 1 commit into
Conversation
…te in HashChainCapacitor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HashChainCapacitorvalidates the stalemaxPacketLengthstate variable instead of its own inputmaxPacketLength_in both the constructor andupdateMaxPacketLength, so theMAX_LEN(10) guard never rejects anything: the constructor checks the default 0, and the update path re-checks the already-set value. Oversized packet lengths install silently. Swapping the two checks to the input fixes it.Fixes #436
Test plan
Three regression tests added to
test/capacitors/HashChainCapacitor.t.sol: oversized constructor input and oversized update input must revert withInvalidPacketLength(both fail on current master), and the boundary value 10 stays accepted.Both changed files pass
prettier@2.8.8 --checkwithprettier-plugin-solidityat the repo-pinned version.