Skip to content

Fix: Build isolated-vm binding for macOS x64 release - #114

Merged
heavyrubberslave merged 1 commit into
mainfrom
fix/macos-x64-release-binding
Oct 2, 2026
Merged

heavyrubberslave merged 1 commit into
mainfrom
fix/macos-x64-release-binding

Conversation

@heavyrubberslave

@heavyrubberslave heavyrubberslave commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

isolated-vm ships no prebuilt binding for darwin-x64, so the release tarball failed to start on Intel Macs (caught by the macos-x64 smoke test).

  • Compile isolated-vm on macos-26-intel and add it to the tarball as node_modules/isolated-vm/prebuilds/darwin-x64/isolated-vm.abi.node
  • Switch macOS x64 runners from macos-15-intel to macos-26-intel

Summary by CodeRabbit

  • Platform Support
    • Release builds now include the native component needed for macOS x64 on Node.js 24, improving compatibility for users on that platform.
  • Build and Test Reliability
    • macOS x64 release smoke tests and automated tests now run on a newer Intel macOS environment. This helps verify release artifacts against the updated platform while preserving the existing macOS x64 platform target.

isolated-vm ships no prebuilt binding for darwin-x64, so the release
tarball failed to start on Intel Macs (caught by the macos-x64 smoke test).

- Compile isolated-vm on macos-26-intel and add it to the tarball as
  node_modules/isolated-vm/prebuilds/darwin-x64/isolated-vm.abi<N>.node
- Switch macOS x64 runners from macos-15-intel to macos-26-intel
@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2e110ed1-96f6-415d-a0f0-6c4f3858b143

📥 Commits

Reviewing files that changed from the base of the PR and between c2fb16b and ec6b64e.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • .github/workflows/test.yml
 _______________________________________________________________________________________________________________
< Walking on water and developing software from a specification are easy if both are frozen. - Edward V. Berard >
 ---------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@heavyrubberslave heavyrubberslave added the patch Creates a new patch/bugfix release if merged label Oct 2, 2026
@heavyrubberslave
heavyrubberslave merged commit eeb632d into main Oct 2, 2026
6 of 7 checks passed
@heavyrubberslave
heavyrubberslave deleted the fix/macos-x64-release-binding branch October 2, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Creates a new patch/bugfix release if merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant