Repository navigation
Fix dynamic REST property lookup - #1479
Open
efegokdemir wants to merge 2 commits into
Open
efegokdemir wants to merge 2 commits into
efegokdemir wants to merge 2 commits into
Conversation
Handle unsupported method names without leaking NameError and retain computed getters when reading optional resource identifiers. Keep internal client access private in test mocks. Correct dispute evidence description types and validate the default-address field without invoking its action method, so REST response checks remain non-vacuous.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1272 and #1273
Unknown REST property getters now raise
NoMethodError, andrespond_to?reports dynamic properties correctly. Dynamic setters and aliased fields remain supported; write operations still treat an absent primary key asnil.How has this been tested?
The focused regression tests pass (4 runs, 16 assertions). The
FulfillmentRequestandResourceFeedbacktests across API versions pass (119 runs, 119 assertions). RuboCop passes for the changed Ruby files.The full REST wrapper suite ran on Ruby 4.0.7/Minitest 6 before the internal missing-key adjustment and reported 10,884 runs with 147 errors. It was not rerun after that adjustment.
srb tcreports two errors outside these changes: an REXML RBI signature conflict and a missingoverrideonAuthQuery#hmac.Checklist: