fix(settings): write settings file atomically via temp + rename - #285
Open
kiwipaulrob wants to merge 2 commits into
Open
kiwipaulrob wants to merge 2 commits into
kiwipaulrob wants to merge 2 commits into
Conversation
kiwipaulrob
marked this pull request as ready for review
September 30, 2026 22:30
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BaseSettings._save(sendspin/settings.py, shared by client and serve settings) rewrites the live JSON file in place withwrite_text. A kill mid-write truncates it, and on next start theJSONDecodeErrorhandler logs a warning and silently falls back to defaults -- volume, name, interface and hooks all revert with no obvious cause.Fix
Write-temp-then-rename: content goes to a
.tmpsibling, is fsynced, thenos.replace()swaps it into place atomically. A crash can now only leave the previous good file behind. SameOSErrorhandling as before.Verification
pytest tests/, excluding serve + audio_devices): 123 passedruff checkcleanCovers both
ClientSettingsandServeSettingssince they share_save.