Repository navigation
Enforce a configurable minimum version for high-score submissions - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #68. Set
MINIMUM_CLIENT_VERSIONto21.3eand compare the numeric major and minor components before the letter suffix. Future cutoff changes only require updating the string constant.The validator accepts
v21.3eand newer releases, rejects older releases, and continues to reject prerelease builds. The tests cover the cutoff, a two-digit minor version, and updating the minimum string.All 13 tests passed locally with Python 3.9 and Django 3.2. The PR workflow tests with Python 3.12 and the project's current dependencies.