Skip to content

add damping tutorial & exercise - #1

Open
charlie0614 wants to merge 1 commit into
mainfrom
add_damping_levels_tutorial
Open

charlie0614 wants to merge 1 commit into
mainfrom
add_damping_levels_tutorial

Conversation

@charlie0614

Copy link
Copy Markdown
Member

No description provided.

@xsaschako xsaschako left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, got minor comments, next time please specify in the PR what to look out for, thank youuu

Comment thread tutorial03_02.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tutorial name doesn't adhere to prior naming scheme but maybe intentional?

Comment thread tutorial03_02.py
@@ -0,0 +1,225 @@
import marimo

__generated_with = "0.24.0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marimo<0.21 in requirements



@app.cell
def _(Damping, model, np):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short comment of that the exercisee should rerun?

ax.plot(time, result_array[1 + int(osecir.InfectionState.InfectedSevere), :], label='Infected Severe')
ax.plot(time, result_array[1 + int(osecir.InfectionState.InfectedCritical), :], label='Infected Critical')

for t_damping, label in [(10, 'school + office closure'), (25, 'mask mandate'),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it renders for me ( nice graphic btw) but the annotations are slightly hard to read because they are on the lines of the states... I dont know how to fix it and maybe not necessary but maybe think abouztit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants