Repository navigation
test: correct cross-platform CI fixtures and name stalled tests - #10
Closed
VolkerChristian wants to merge 1 commit into
Closed
VolkerChristian wants to merge 1 commit into
VolkerChristian wants to merge 1 commit into
Conversation
Member
Author
|
Closing as superseded by the CI fixes merged in PR #11. CI is now green on Linux, Windows, and macOS. The remaining test coverage and timeout changes in this PR are optional and are not required for the CI repair. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 2 — approved bounded fixture corrections and named-test safety net
This is not a claim that AutoTalk CI is fixed. Run #6: https://github.com/SNodeC/AutoTalk/actions/runs/38188305193.
Root cause and boundary
The fake vLLM worker fixture patched runtime.speech_backend but not the separate binding imported by services. On macOS the real mlx selection therefore discarded the fixture's vLLM progress messages. Patch both existing consumer bindings. The QObject lifetime fixture tested unsupported native capture on macOS despite stubbing capture start; model Linux within this fixture only and explicitly retain/test the real unsupported-platform guard for macOS and Windows.
Add the owner-approved pytest-timeout 2.4.0 safety net (300 seconds, thread method) so future test hangs fail with a named test. No job timeout extension, additional skips, weakened assertions, product-code changes or workflow changes.
Verification
test_real_sigint_runs_cleanup_and_reaps_speech_childsubprocess exceeds its existing 10-second wait after SIGINT. That independent defect remains unresolved; its limit was not changed.docs-audit --repo .: 0 violations.git diff --check: passed.The one-hour Ubuntu/Windows CI hang was not reproduced locally and is not claimed resolved. No healthy all-platform runtime established. No GitHub CI dispatch for this branch; CI remains manual-only.
Accounting
Production application code: 0 lines changed. Configuration: +3/-1. Tests: +10/-0. No licences, tags, settings or defaults changed.