Repository navigation
docs: Step 2 shared visual design - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 items
2.1, 2.4, 2.5
No merge, tag or repository-setting changes. No CI dispatch in Step 2; the Step 1 documentation-only publication was separately authorized and completed. Existing caller/template refs already use @main and are unchanged (item 2.6 was superseded). Typography and glyphs are generated by the single shared renderer. GitHub gate passed before rollout at 390/1440 px in both themes: three specified source elements per right button plus fallback img survive, correct intrinsic 36×28 / 160×28 sizes, same-row phone geometry and unchanged desktop box sizes (including native GitHub padding).
Files
README.mddocs/media/nav/organization-dark.svgdocs/media/nav/organization-light.svgnavigation/README.mdnavigation/plan.ymlprofile/media/menu/applications.svgprofile/media/menu/community.svgprofile/media/menu/framework.svgprofile/media/menu/infrastructure.svgprofile/media/menu/learn.svgprofile/media/menu/suites.svgtests/test_navigation.pytools/snodec_sync/navigation.pyVerification
python3 -m unittest discover -s tests -v: 68 passed.python3 <control checkout>/tools/snodec_sync docs-audit --repo <checkout>: 0 violations.python3 <control checkout>/tools/snodec_sync page-headers --repo <checkout> --check: passed.git diff --check: passed. No tests weakened; new shapes replace the old geometry assertion to match the approved spec.Final visual review
Public native-GitHub review covered 40 page/width/theme cases, plus the initial snode.c gate and final full-width root captures: no broken images. Intrinsic desktop heroes are 1280×320; new phone heroes are 640×372, and the existing snode.c/MQTTSuite phone SVGs are byte-identical. All remaining title menus are normalized to 160×28, including the source-build Native Linux/OpenWrt menus; full meaning remains in alt/title text.
Native wrapping limitations remain explicit: five-column status tables overflow horizontally on phones; DistributionPackages’ long H1 wraps naturally; legend symbols can detach from labels at 390px. A word-joiner was measured ineffective and removed; no CSS fallback, table navigation redesign or palette/shape rollback was introduced.
Final verification
Optional docs-audit: 0 violations at the edited/exported boundary. page-headers --check: passed. Staged/final diff checks: passed. No Step 2 merge or publication has occurred.