Skip to content

Gen2 Production PR: Update to SBND LightPropagation Module #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VCLanNguyen wants to merge 1 commit into
base: production/sbnd-gen2
Choose a base branch
from
Open

Gen2 Production PR: Update to SBND LightPropagation Module #967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sbndcode/JobConfigurations/standard/caf/cafmakerjob_sbnd_data_sce.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ physics.producers.cafmaker.OpT0Label: "opt0finderSCE"
physics.producers.cafmaker.TPCPMTBarycenterMatchLabel: "tpcpmtbarycentermatchingSCE"
physics.producers.cafmaker.CVNLabel: "cvnSCE"
physics.producers.cafmaker.LightCaloLabel: "lightcaloSCE"
physics.producers.cafmaker.CorrectedOpFlashLabel: "lightpropagationcorrectionSCE"

physics.producers.cnnid.WireLabel: "sptpc2d:dnnsp"
physics.producers.cafmaker.BlipTag: "blipreco"
Expand Down
2 changes: 1 addition & 1 deletion sbndcode/JobConfigurations/standard/reco/reco2_data.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ physics.reco2: [ pandora, pandoraTrack, blipPandoraCopy, blipPandoraTrackCopy, p
cvn, opt0finder, crtveto, crtspacepointmatching, crttrackmatching, tpcpmtbarycentermatching,
pandoraSCE, pandoraSCETrack, pandoraSCEShower, pandoraSCEShowerSBN, pandoraSCECaloData, pandoraSCEPidData, pandoraSCELikePidData,
cvnSCE, opt0finderSCE, tpcpmtbarycentermatchingSCE, crtspacepointmatchingSCE, crttrackmatchingSCE,
caloskimCalorimetry, blipreco, lightpropagationcorrectionSCE, lightcaloSCE, frameshift]
caloskimCalorimetry, blipreco, frameshift, lightpropagationcorrectionSCE, lightcaloSCE]


physics.analyzers.caloskim.G4producer: ""
Expand Down
53 changes: 23 additions & 30 deletions sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ sbnd::LightPropagationCorrection::LightPropagationCorrection(fhicl::ParameterSet
fOpFlashLabel_tpc1 ( p.get<std::string>("OpFlashLabel_tpc1") ),
fSpacePointLabel( p.get<std::string>("SpacePointLabel") ),
fOpHitsModuleLabel( p.get<std::string>("OpHitsModuleLabel") ),
fSPECTDCLabel( p.get<std::string>("SPECTDCLabel") ),
fFrameShiftInfoLabel( p.get<std::string>("FrameShiftInfoLabel") ),
fFlashMatchingTool( p.get<std::string>("FlashMatchingTool") ),
fSaveCorrectionTree( p.get<bool>("SaveCorrectionTree") ),
fSpeedOfLight( p.get<double>("SpeedOfLight") ),
Expand Down Expand Up @@ -128,10 +128,27 @@ void sbnd::LightPropagationCorrection::produce(art::Event & e)
std::vector< art::Ptr<recob::Slice> > sliceVect;
art::fill_ptr_vector(sliceVect, sliceHandle);

// Get the FrameShiftInfo product required to go to the RWM/gate reference frame
bool haveFrameShiftInfo = true;
if(!fIsMC)
{
// Data: stream-agnostic -- FrameApplyAtCaf is already resolved per-stream (BNB/Offbeam/Xmuon) by FrameShift_module
art::Handle<sbnd::timing::FrameShiftInfo> frameShiftHandle;
e.getByLabel(fFrameShiftInfoLabel, frameShiftHandle);
if (!frameShiftHandle.isValid()){
std::cout << "No FrameShiftInfo product found. Skip this event." << std::endl;
haveFrameShiftInfo = false;
}
else{
fFrameApplyAtCaf = frameShiftHandle->FrameApplyAtCaf();
}
}
// MC: block above is skipped, fFrameApplyAtCaf stays 0 -- no shift applied

//Vector for recob PFParticles
std::vector<art::Ptr<recob::PFParticle>> pfpVect;
// --- Get the candidate slices
for(size_t ix=0; ix<sliceVect.size(); ix++){
for(size_t ix=0; ix<sliceVect.size() && haveFrameShiftInfo; ix++){
ResetSliceInfo();
// --- Get the slice
auto & slice = sliceVect[ix];
Expand Down Expand Up @@ -200,29 +217,7 @@ void sbnd::LightPropagationCorrection::produce(art::Event & e)
continue; // Skip to the next slice if the nu score is below threshold
}
this->GetPropagationTimeCorrectionPerChannel();

// Get the SPECTDC product required to go to the RWM reference frame

if(!fIsMC)
{
art::Handle<std::vector<sbnd::timing::DAQTimestamp>> tdcHandle;
e.getByLabel(fSPECTDCLabel, tdcHandle);
if (!tdcHandle.isValid() || tdcHandle->size() == 0){
std::cout << "No SPECTDC products found. Skip this event." << std::endl;
ResetSliceInfo();
continue;
}
else{
const std::vector<sbnd::timing::DAQTimestamp> tdc_v(*tdcHandle);
for (size_t i=0; i<tdc_v.size(); i++){
auto tdc = tdc_v[i];
const uint32_t ch = tdc.Channel();
const uint64_t ts = tdc.Timestamp();
if(ch == 2) fRWMTime = ts%uint64_t(1e9);
if(ch == 4) fEventTriggerTime = ts%uint64_t(1e9);
}
}
}
// Get all the OpT0 objects associated to the slice
std::vector<art::Ptr<recob::OpFlash>> flashFM;
if(fFlashMatchingTool == "OpT0Finder" ){
Expand Down Expand Up @@ -282,8 +277,6 @@ void sbnd::LightPropagationCorrection::beginJob()
fTree->Branch("eventID", &fEvent, "eventID/i");
fTree->Branch("runID", &fRun, "runID/i");
fTree->Branch("subrunID", &fSubrun, "subrunID/i");
fTree->Branch("RWMTime", &fRWMTime);
fTree->Branch("EventTriggerTime", &fEventTriggerTime);
fTree->Branch("NuScore", &fNuScore);
fTree->Branch("FMScore", &fFMScore);
fTree->Branch("OpFlashTimeOld", &fOpFlashTimeOld);
Expand Down Expand Up @@ -317,8 +310,7 @@ void sbnd::LightPropagationCorrection::ResetEventVars()
fRun = 0;
fSubrun = 0;
_fNuScore = 0.0;
fRWMTime=0.;
fEventTriggerTime=0.;
fFrameApplyAtCaf=0.;
fNuScore.clear();
fFMScore.clear();
fOpFlashTimeOld.clear();
Expand Down Expand Up @@ -630,10 +622,11 @@ void sbnd::LightPropagationCorrection::CorrectOpFlash(art::Ptr<recob::OpFlash> c
newFlashTime = flasht0;
particlePropTime = GetAverageParticlePropagationTime()/1000;
photonPropTime = GetAveragePhotonPropagationTime()/1000;
correctedOpFlashTiming.OpFlashT0 = originalFlashTime + fEventTriggerTime/1000 - fRWMTime/1000;
double const frameShift_us = fFrameApplyAtCaf/1000.;
correctedOpFlashTiming.OpFlashT0 = originalFlashTime + frameShift_us;
correctedOpFlashTiming.NuToFLight = (Zcenter/fSpeedOfLight)/1000;
correctedOpFlashTiming.NuToFCharge = (fRecoVz/fSpeedOfLight)/1000;
correctedOpFlashTiming.OpFlashT0Corrected = newFlashTime + fEventTriggerTime/1000 - fRWMTime/1000;;
correctedOpFlashTiming.OpFlashT0Corrected = newFlashTime + frameShift_us;
correctedOpFlashTiming.ParticlePropagationTime = particlePropTime;
correctedOpFlashTiming.PhotonPropagationTime = photonPropTime;
}
Expand Down
7 changes: 3 additions & 4 deletions sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
#include "sbnobj/Common/Reco/CRUMBSResult.h"
#include "sbnobj/Common/Reco/TPCPMTBarycenterMatch.h"
#include "sbnobj/Common/Reco/CorrectedOpFlashTiming.h"
#include "sbnobj/SBND/Timing/DAQTimestamp.hh"
#include "sbnobj/SBND/Timing/FrameShiftInfo.hh"
#include "lardataobj/AnalysisBase/T0.h"

// Geometry and mapping
Expand Down Expand Up @@ -174,7 +174,7 @@ private:
std::string fSpacePointLabel;
std::string fOpHitsModuleLabel;
std::string fOpFlashNewLabel;
std::string fSPECTDCLabel;
std::string fFrameShiftInfoLabel;
std::string fFlashMatchingTool;

bool fSaveCorrectionTree;
Expand Down Expand Up @@ -232,8 +232,7 @@ private:
size_t fNOpChannels;
double _fNuScore;
double _fFMScore;
double fEventTriggerTime=-999999.;
double fRWMTime=-999999.;
double fFrameApplyAtCaf=0.; // MC: stays 0, no shift applied
std::vector<double> fNuScore;
std::vector<double> fFMScore;
std::vector<double> fOpFlashTimeOld;
Expand Down
2 changes: 1 addition & 1 deletion sbndcode/LightPropagationCorrection/job/sbnd_lightpropagationcorrection_config.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ LightPropagationCorrection:
SpacePointLabel: "pandora"
OpT0FinderModuleLabel: "opt0finder"
TPCPMTBarycenterFMModuleLabel: "tpcpmtbarycentermatching"
SPECTDCLabel: "tdcdecoder"
FrameShiftInfoLabel: "frameshift"

VGroupVUV: @local::sbnd_vuv_timing_parameterization.vuv_vgroup_mean
VGroupVIS: @local::sbnd_vis_timing_parameterization.vis_vmean
Expand Down