Skip to content

Feature/acastill lightprop gen2 #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aantonakis merged 14 commits into from
Sep 24, 2026
Merged

Feature/acastill lightprop gen2 #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
72a6813
Modify light propagation correction to include particle propagation time
asanchezcastillo Jul 6, 2026
6f37476
Add pdfraction as parameter
asanchezcastillo Jul 6, 2026
04271a3
Clean code adding correctopflash function
asanchezcastillo Jul 7, 2026
b9efe8b
Add lightprop correction in default MC reco2 workflow
asanchezcastillo Jul 7, 2026
990f5b3
fcl refactoring
asanchezcastillo Jul 21, 2026
cc9820b
Change light prop module to not read RWM and ETT in MC
asanchezcastillo Jul 29, 2026
12a3b3a
Merge branch 'production/sbnd-gen2' into feature/acastill_lightprop_gen2
asanchezcastillo Jul 29, 2026
8e335eb
Fix issue with nopchannels
asanchezcastillo Jul 29, 2026
aa45ac8
Merge branch 'feature/acastill_lightprop_gen2' of github.com:SBNSoftw…
asanchezcastillo Jul 29, 2026
106b004
Fix copy-paste issue with return
asanchezcastillo Sep 1, 2026
ac555d8
Keep event-by-event initialisation consistent
asanchezcastillo Sep 1, 2026
d2bdc03
Add pdtype declaration to avoid calling pdType function
asanchezcastillo Sep 1, 2026
a224352
Keep consistent use of associations
asanchezcastillo Sep 1, 2026
c51a263
Merge branch 'production/sbnd-gen2' into feature/acastill_lightprop_gen2
aantonakis Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sbndcode/JobConfigurations/standard/caf/cafmakerjob_sbnd.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,12 @@ physics.producers.cafmaker.FlashMatchSCECryoSuffixes: [""]
physics.producers.cafmaker.TrackHitFillRRStartCut: 1000
physics.producers.cafmaker.TrackHitFillRREndCut: 1000

# Include 3D barycenter flahs matching
# Include 3D barycenter flash matching
physics.producers.cafmaker.TPCPMTBarycenterMatchLabel: "tpcpmtbarycentermatching"

# Include propagation correction on the flash timing
physics.producers.cafmaker.CorrectedOpFlashLabel: "lightpropagationcorrectionSCE"

# Include MC version of PMT Software Trigger
physics.producers.cafmaker.SBNDSoftwareTriggerLabel: "pmtmetricmc"

Expand Down
1 change: 0 additions & 1 deletion sbndcode/JobConfigurations/standard/caf/cafmakerjob_sbnd_data_sce.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ physics.producers.cafmaker.SBNDCRTTrackMatchLabel: "crttrackmatchingSCE"
physics.producers.cafmaker.OpT0Label: "opt0finderSCE"
physics.producers.cafmaker.TPCPMTBarycenterMatchLabel: "tpcpmtbarycentermatchingSCE"
physics.producers.cafmaker.CVNLabel: "cvnSCE"
physics.producers.cafmaker.CorrectedOpFlashLabel: "lightpropagationcorrectionSCE"
physics.producers.cafmaker.LightCaloLabel: "lightcaloSCE"

physics.producers.cnnid.WireLabel: "sptpc2d:dnnsp"
Expand Down
3 changes: 3 additions & 0 deletions sbndcode/JobConfigurations/standard/reco/config/workflow_reco2.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include "SBNDCVNMapper.fcl"
#include "blipreco_configs.fcl"
#include "lightcalo_sbnd.fcl"
#include "sbnd_lightpropagationcorrection_config.fcl"

BEGIN_PROLOG

Expand Down Expand Up @@ -82,6 +83,7 @@ sbnd_reco2_producers:{
opt0finderSCE: @local::sbnd_opt0_finder_one_to_many
tpcpmtbarycentermatching: @local::TPCPMTBarycenterMatchProducerMC
tpcpmtbarycentermatchingSCE: @local::TPCPMTBarycenterMatchProducerSCEMC
lightpropagationcorrectionSCE: @local::LightPropagationCorrectionSCEMC

### Uncalibrated calorimetry producer for calibration caloskimmer
caloskimCalorimetry: @local::caloskim_calorimetry
Expand Down Expand Up @@ -136,6 +138,7 @@ sbnd_reco2_producer_sequence: [
#, fmatchoparaSCE
, opt0finderSCE
, tpcpmtbarycentermatchingSCE
, lightpropagationcorrectionSCE
, cvn
, cvnSCE
, blipreco
Expand Down
12 changes: 10 additions & 2 deletions sbndcode/LightPropagationCorrection/LightPropagationCorrectionAna_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ class LightPropagationCorrectionAna : public art::EDAnalyzer {
double fNuToFLight;
double fNuToFCharge;
double fOpFlashT0Corrected;
double fParticlePropagationTime;
double fPhotonPropagationTime;

unsigned int _eventID;
unsigned int _runID;
Expand All @@ -76,6 +78,8 @@ void LightPropagationCorrectionAna::analyze(art::Event const& e)
fNuToFLight=-99999.;
fNuToFCharge=-99999.;
fOpFlashT0Corrected=-99999.;
fParticlePropagationTime=-99999.;
fPhotonPropagationTime=-99999.;

_eventID = -1;
_runID = -1;
Expand All @@ -95,7 +99,6 @@ void LightPropagationCorrectionAna::analyze(art::Event const& e)
return;
}


std::vector<art::Ptr<sbn::CorrectedOpFlashTiming>> correctedopflash_v;
art::fill_ptr_vector(correctedopflash_v, correctedopflash_h);

Expand All @@ -121,11 +124,15 @@ void LightPropagationCorrectionAna::analyze(art::Event const& e)
std::cout << "Corrected flash time light only " << correctedopflash->NuToFLight << std::endl;
std::cout << "Corrected flash time tpc z corr " << correctedopflash->NuToFCharge << std::endl;
std::cout << "Corrected flash time prop corr tpc z corr " << correctedopflash->OpFlashT0Corrected << std::endl;
std::cout << "Particle propagation time " << correctedopflash->ParticlePropagationTime << std::endl;
std::cout << "Photon propagation time " << correctedopflash->PhotonPropagationTime << std::endl;

fOpFlashT0 = correctedopflash->OpFlashT0;
fNuToFLight = correctedopflash->NuToFLight;
fNuToFCharge = correctedopflash->NuToFCharge;
fOpFlashT0Corrected = correctedopflash->OpFlashT0Corrected;
fParticlePropagationTime = correctedopflash->ParticlePropagationTime;
fPhotonPropagationTime = correctedopflash->PhotonPropagationTime;
fTree->Fill();
}
}
Expand All @@ -144,7 +151,8 @@ void LightPropagationCorrectionAna::beginJob()
fTree->Branch("fNuToFLight", &fNuToFLight, "NuToFLight/d");
fTree->Branch("fNuToFCharge", &fNuToFCharge, "NuToFCharge/d");
fTree->Branch("fOpFlashT0Corrected", &fOpFlashT0Corrected, "OpFlashT0Corrected/d");

fTree->Branch("fParticlePropagationTime", &fParticlePropagationTime, "ParticlePropagationTime/d");
fTree->Branch("fPhotonPropagationTime", &fPhotonPropagationTime, "PhotonPropagationTime/d");
}

DEFINE_ART_MODULE(LightPropagationCorrectionAna)
Loading