Repository navigation
Fix Marketplace publishing - #16
Merged
Merged
Conversation
- Separate the VSIX manifest tags with semicolons: VsixPublisher reads them as one 145-character tag otherwise (maximum 50). - Run VsixPublisher from bin\lib, where its dependencies are; the copy under bin crashes while initializing telemetry.
There was a problem hiding this comment.
🟡 Changes recommended
The manifest unintentionally removes the existing Source Control Client tag.
1 open finding
What changed in this PR
Updates Marketplace publishing after the first tagged release failure.
Changes:
- Uses semicolon-separated Marketplace tags.
- Selects the dependency-complete
VsixPublisherexecutable.
| File | Description |
|---|---|
SourceControlSwitcher/Manifest/source.extension.vsixmanifest |
Updates tag delimiters. |
.github/workflows/release.yml |
Selects VsixPublisher from bin\lib. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <ReleaseNotes>Resources\CHANGELOG.txt</ReleaseNotes> | ||
| <Icon>Resources\Icon.png</Icon> | ||
| <Tags>Source Control, Source Code Control, Source Control Provider, Source Control Client, Git, SVN, Subversion, TFVC, Team Foundation, Perforce, Helix</Tags> | ||
| <Tags>Source Control;Source Code Control;Source Control Provider;Git;SVN;Subversion;TFVC;Team Foundation;Perforce;Helix</Tags> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the first tagged release run: manifest tags are now separated by semicolons, and the release workflow runs the VsixPublisher copy that ships with its dependencies.