Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search_rocket unpacks get_inertias() in the wrong order:
get_inertias returns (longitudinal, rotational) and rocket.py:24 assigns it to inertia_z, inertia_i, so rocket.inertia comes out as (rotational, rotational, longitudinal). In OpenRocket, "longitudinal" is the pitch/yaw inertia, not the roll inertia. AbstractRKSimulationStepper.java (328-330) in RocketPy divides the "longitudinal" inertia into pitch and yaw moments.
This PR swaps the unpack order (single line change) and adds a test that asserts that roll inertia < pitch inertia, skipping examples with no inertia data. This test fails initially and passes with the fix.
Also fixed the order in the example parameters.json files and tests.