Repository navigation
Add Macroscope ignore file scoped to this repo - #1682
Merged
Merged
Conversation
Macroscope's built-in ignore list skips test files, which means our Vitest and Cypress specs are never reviewed. Opting tests back in needs a custom .macroscope/ignore.md, and a custom file replaces the defaults rather than extending them. Of the ~170 default patterns, only four match files this repo tracks: yarn.lock, *.lock, *.svg and package.json. We keep yarn.lock and *.svg, drop *.lock (it only matched yarn.lock), and drop package.json because dependency and script changes are worth reviewing. On top of that we skip files that are vendored or written by tools: the Yarn release checked in via yarnPath, the vendored p5.js bundle, Crowdin-written locale files (en.json stays reviewed), and the mock Scratch API responses under public/api/scratch. Alternatives considered: copying the full default list was rejected because almost none of it matches anything here and it would hide package.json. Binary files (.whl, .glb, .sb3) are left out because Macroscope always excludes binaries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zetter-rpf
approved these changes
Oct 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Written by AI, Reviewed by Adrian's eyes.
What
Adds
.macroscope/ignore.mdso that Macroscope reviews our tests and skips only the vendored or tool-written files this repo actually tracks.Why
By default, Macroscope skips test files, so our Vitest and Cypress specs never get reviewed. Turning tests on (
ignoreTests: false) needs a custom ignore file. A custom file replaces Macroscope's default patterns instead of adding to them, so this file lists only patterns that match files in this repo.Patterns
**/yarn.lockyarn.lock**/*.svgsrc/assets/**/.yarn/releases/**yarn-4.12.0.cjs(3 MB)yarnPath**/public/libraries/**p5.js(4.4 MB)**/public/translations/*-*.jsonen.jsonis still reviewed**/public/api/scratch/**Defaults left out
**/package.json: dependency and script changes should be reviewed.**/*.lock: only matchedyarn.lock, which is already covered..whl,.glb,.sb3): Macroscope always skips these.Trade-offs to be aware of
public/api/scratch/projects/cool-scratch.jsonis also the fixture thatcypress/e2e/spec-scratch.cy.jsloads, so changes to it won't be reviewed.vite-plugin-svgr, so SVG markup changes won't be reviewed.**/public/libraries/**will also skip any file added to that folder later, not just p5.js.🤖 Generated with Claude Code