Skip to content

Remove scratch project type - #1053

Open
zetter-rpf wants to merge 4 commits into
mainfrom
remove-scratch-project-type
Open

zetter-rpf wants to merge 4 commits into
mainfrom
remove-scratch-project-type

Conversation

@zetter-rpf

Copy link
Copy Markdown
Contributor

Status

What's changed?

This removes:

  • the temporary endpoints we put in place for the Scratch migration
  • the scratch project type
  • the experience CS project import as projects are now synced on creation

I've also added validation to project types as for https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1884 to prevent projects of type 'scratch' from re-appearing.

@cla-bot cla-bot Bot added the cla-signed label Oct 9, 2026
zetter-rpf and others added 2 commits October 9, 2026 16:29
Previously every release ran projects:create_experience_cs_examples,
re-creating a hardcoded list of Scratch example projects.

When new projects were added to Experience CS, they had to be
put in this list too.

We no longer need this list as now projects are synced from
Experience CS directly when they are created.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
These were temporary endpoints used for the one-off project migration.

The service account is still used for public project create/update and
global Scratch asset upload.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Test coverage

94.1% line coverage reported by SimpleCov.
Run: https://github.com/RaspberryPiFoundation/editor-api/actions/runs/37952623320

This was here for Experience CS projects which have now been
migrated to code_editor_scratch.

Salesforce still expects 'scratch' as the teacherprojecttype__c
picklist value for Experience CS lessons, so LessonSyncJob keeps
sending that string via its own constant rather than deriving it from
Project::Types.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@raspberrypiherokubot
raspberrypiherokubot temporarily deployed to editor-api-p-remove-scr-6cqgub October 9, 2026 15:31 Inactive
Make sure that we only save expected project types.
I'm doing this so that new scratch projects don't sneak in from
experience CS api calls or the project importer.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@zetter-rpf

Copy link
Copy Markdown
Contributor Author

@macroscope-app you there?

@zetter-rpf

Copy link
Copy Markdown
Contributor Author

@macroscope-app why haven't you reviewed this?

@macroscopeapp

macroscopeapp Bot commented Oct 9, 2026

Copy link
Copy Markdown

I can’t inspect this repository’s review configuration or run history here. If reviews are manual-only, trigger one with @macroscope-app review; otherwise check the repo’s review mode and skip settings: https://docs.macroscope.com/bug-detection-and-fixes

@zetter-rpf

Copy link
Copy Markdown
Contributor Author

@macroscope-app review

@macroscopeapp

macroscopeapp Bot commented Oct 9, 2026

Copy link
Copy Markdown

Manual reviews triggered for commit 81a47ee:

All prior checks · these links stay valid even if you push more commits.

@macroscopeapp

macroscopeapp Bot commented Oct 9, 2026

Copy link
Copy Markdown

Review triggered; results will be posted as check runs.

This branch was successfully deployed

1 active deployment
editor-api-p-remove-scr-6cqgub — 81a47eee Deployed Oct 9, 2026 by zetter-rpf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants