Skip to content

(docs: changelog )master -> main - #1781

Merged
grantmcdermott merged 1 commit into
mainfrom
changelog-main-rename
Sep 27, 2026
Merged

grantmcdermott merged 1 commit into
mainfrom
changelog-main-rename

Conversation

@grantmcdermott

Copy link
Copy Markdown
Contributor

Missing bullet from the changelog merge

@eitsupi

eitsupi commented Sep 26, 2026

Copy link
Copy Markdown
Member

In my opinion, this is unrelated to the 3.0.0 release and therefore should not be included in the changelog.

Perhaps @randy3k didn't use GitHub's feature to change the branch name, but instead pushed a different main branch?
If we had used GitHub's feature to switch branch name, it should have been automatically routed, so there shouldn't have been a problem.

@grantmcdermott

Copy link
Copy Markdown
Contributor Author

Agree to disagree, but imo it's part of the same organizational changes that have been implemented as part of this release cycle. It feel it's a change that should be documented somewhere too.

@eitsupi

eitsupi commented Sep 26, 2026

Copy link
Copy Markdown
Member

In my opinion, CHANGELOG is for users, not developers.
That said, if the default branch name of git is important somewhere I'm unaware of (a large company?), I wouldn't actively oppose adding it.

@eitsupi
eitsupi requested review from Fred-Wu, randy3k and renkun-ken and removed request for eitsupi September 26, 2026 23:27
@randy3k

randy3k commented Sep 27, 2026

Copy link
Copy Markdown
Member

IMO, I think it is valid change that could be documented. Though it is also okay to skip it entirely.

Ya, reflecting back, i should have renamed the branch instead of pushing a new one.

@renkun-ken renkun-ken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grantmcdermott
grantmcdermott merged commit 205fd96 into main Sep 27, 2026
5 checks passed
@grantmcdermott
grantmcdermott deleted the changelog-main-rename branch September 27, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants