Skip to content

chore: prepare 3.0.0 release - #1779

Merged
grantmcdermott merged 3 commits into
REditorSupport:mainfrom
eitsupi:release/3.0.0
Sep 26, 2026
Merged

grantmcdermott merged 3 commits into
REditorSupport:mainfrom
eitsupi:release/3.0.0

Conversation

@eitsupi

@eitsupi eitsupi commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

Summary

Prepare the v3.0.0 release by replacing the release-candidate version and organizing the changelog around changes relevant to users upgrading from 2.8.8. Keep the README overview concise and point to the changelog for upgrade details.

Changes

  • Set the extension and lockfile version to 3.0.0.
  • Rewrite the 3.0.0 changelog with feature highlights and upgrade notes for the session integration, setting changes and removals, Live Share removal, and the VS Code 1.110 minimum.
  • Update the README release overview and installation requirement.

Closes #1769

@eitsupi eitsupi changed the title Prepare v3.0.0 release chore: prepare 3.0.0 release Sep 26, 2026

@grantmcdermott grantmcdermott left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd already started working on my own CHANGELOG updates and just incorporated them more or less directly into yours. You might want to scan over, but I think it looks good as-is (certainly much more readable and clearer to follow than it was before).

@grantmcdermott
grantmcdermott merged commit 0dce793 into REditorSupport:main Sep 26, 2026
5 checks passed
@eitsupi
eitsupi deleted the release/3.0.0 branch September 26, 2026 23:07
@eitsupi

eitsupi commented Sep 26, 2026

Copy link
Copy Markdown
Member Author

Thank you, but I was going to wait for reviews from others before merging.

@eitsupi eitsupi left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChatGPT-generated review, based on comparing the current CHANGELOG against the 3.0.0 implementation and manifest behavior.

I noticed three user-facing wording issues where the current CHANGELOG is broader than the implementation:

  1. r.plot.useHttpgd is not a simple behavior-preserving rename.
    The "Renamed settings" section currently says that the deprecated names still work and that existing configurations will continue to behave as before. That is not true for r.plot.useHttpgd: false: in 2.8.8, false selected the standard viewer, while in 3.0.0 the legacy setting only has an effect when it is true; otherwise backend resolution falls back to auto, which may select jgd or httpgd if installed.

    A more precise migration note would be that r.plot.useHttpgd: true continues to select httpgd while r.plot.backend remains auto, and users who want to preserve the old false behavior should set r.plot.backend: "standard" explicitly.

  2. Automatic reconnect applies to managed R terminals/sessions.
    The Session section currently says: "R terminals now reconnect automatically after reloading the VS Code window." The reconnect logic in #1764 is for managed terminals with vscode-R discovery metadata. "Managed R terminals now reconnect automatically..." would more accurately describe the behavior and avoid implying that arbitrary externally started R processes are automatically recovered.

  3. The console fallback description omits the legacy r.rterm.<platform> precedence.
    The CHANGELOG currently says: "If r.consolePath is unset, r.executablePath is used for the console too." The actual resolution order is r.consolePath → legacy r.rterm.<platform> → explicitly configured r.executablePath → system R.

    This could be clarified as: "If neither r.consolePath nor the legacy r.rterm.<platform> setting is set, an explicitly configured r.executablePath is used for the console too."

These are documentation accuracy issues only, but tightening the wording would help users migrating existing configurations to 3.0.0.

@grantmcdermott

Copy link
Copy Markdown
Contributor

certainly much more readable and clearer to follow than it was before

To clarify: this was a comment about the changelog before your (and my) refactor. I wasn't trying to say my incremental changes were much better than yours...

@eitsupi

eitsupi commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

I see. To clarify, though, that wording wasn't what disappointed me.

What concerned me was that you pushed substantial changes directly to my PR branch and then approved and merged the PR without getting agreement or review from anyone else.

More generally, if someone has both permission to modify another person's PR and permission to approve it, this workflow means they can effectively introduce and approve their own changes without any independent review. That seems to undermine the purpose of requiring an approval in the first place.

So I think this may actually be something we should address in the repository settings.
For example, by requiring approval from someone other than the person who made the most recent reviewable push.

@randy3k

randy3k commented Sep 28, 2026

Copy link
Copy Markdown
Member

I think this may actually be something we should address in the repository settings.

Agree. (TBH, I don't even know such setting exists at all).
image

@grantmcdermott

Copy link
Copy Markdown
Contributor

TBC I agree too. But in my defense for this particular case, we had an unfortunate sequence of timing / competing PRs after I said I would submit one for #1769, and interpreted the subsequent comment about merging these together as tacit approval. (Preempted, in turn, by an earlier request not to block merges through minor revision requests... Which shaped my prior.) I would obviously not do this for material code changes. But it's good to set form collaboration norms going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polish changelog for 3.0.0 release

3 participants