Repository navigation
Adopt GitHub App authentication for protected Binance maintenance - #351
Merged
Merged
Conversation
…anch Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protected binance-runtime environment permits only runtime-production, so the App authentication merged to main has not been adopted by the maintenance entry point. This adopts only the five maintenance files from #350 onto runtime-production and extends the isolated authentication check to serially mint the read/write Environment permission variants used by plan/apply. Both checks perform GET requests only; they do not read risk-authority JSON, update configuration, or dispatch trading.
The runtime workflow, runtime source, release pin, approved workflow pin, and trading controls are unchanged. The existing difference between runtime-production and BINANCE_RUNTIME_WORKFLOW_SHA remains a separate release issue and is not approved by this PR. Keep the old maintenance PAT until the deployed App authentication check succeeds and its token revocation is confirmed.
Validation: 51 focused authority/workflow tests passed; actionlint, ruff, five-file scope checks, credential-pattern checks, and diff checks passed. Independent permissions review passed. Real hosted authentication is pending until adoption.