Repository navigation
fix: avoid adoption false alarms from normal health cycles - #339
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily-only release adoption compares raw systemd execution properties, including health-cycle timestamps, PIDs and runtime state. A normal independent health cycle can therefore produce an unknown adoption result when its configuration is unchanged.
Compare stable command/configuration identity, preserve ignore-errors semantics, reject unexpected additional prestart commands, and return a fixed postflight failure reason. Daily code/idle checks and timer preservation remain enforced; real health configuration changes still stop with the recovery snapshot retained. The production runtime consumer is unchanged, so this tooling fix requires no additional service cutover.
Validation: 11 adoption regression tests passed, including runtime-state/timestamp churn, real configuration changes, both additional-command separator formats, consecutive upgrades and immutable-source preservation. Associated installer/pipeline suites, Bash syntax, Ruff and diff checks passed; candidate CI runs all three suites. No production retry or notification was performed.