Repository navigation
Fix comparator decomposition register restoration - #492
Open
AthulKampiyil wants to merge 3 commits into
Open
AthulKampiyil wants to merge 3 commits into
AthulKampiyil wants to merge 3 commits into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #491.
The
ComparatorQuantumdecomposition could modify its input registers because the cleanup sequence did not reverse the order of dependent gate operations.This change corrects the cleanup loop ordering and adds regression tests to verify that both input registers are restored and that the comparison bit follows the documented XOR semantics.
The tests exercise the arithmetic decomposition path and cover all 128 combinations of three-bit operands and the initial comparison-bit value.
Tests
pytest projectq/libs/math/_quantummath_test.py -k "comparator" -v— 10 passed, 39 deselected.pytest projectq/libs/math/— 87 passed, 5 skipped.pytest— 972 passed, 395 skipped, 0 failed.flake8 projectq/libs/math/_quantummath.py projectq/libs/math/_quantummath_test.py— passed with no errors.git diff --check— passed with no issues.