Add test coverage for check-duplicate-docs warning (issue #115) - #92
Open
jnasbyupgrade wants to merge 1 commit into
Open
jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
Add tests for pgxntool commit c364507 (Warn when DOCS lists the same file more than once): - Verify all target depends on check-duplicate-docs - Verify no false-positive warning on template's own DOCS - Verify warning fires with exact text when duplicate added after include Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 3 new tests covering the
check-duplicate-docsphony target introduced in pgxntool PR #124:all depends on check-duplicate-docs (issue #115)— structural check viamake -p -ncheck-duplicate-docs stays quiet on template's own DOCS (issue #115)— no false positivescheck-duplicate-docs warns about a duplicate added after base.mk is included (issue #115)— catches user errorsAll tests pass locally.
Paired with: Postgres-Extensions/pgxntool#124
🤖 Generated with Claude Code