Types Should be Removed from Pokémon Forms

[SamuelAppleby]

Describe the Bug

Altered Pokémon Types are stored in pokemon-form//types. Any Pokémon that has a new mechanical change is guaranteed to have an entry in pokemon/. As pokemon-form are visual only, we should not store types here.

Steps to Reproduce

Query a Pokémon form pokemon-form/. There is a types field, which should not be there; the new entry in pokemon/ will store the types.

e..g, pokemon-form/castform-sunny stores fire, but this is already obtainable from the types field in pokemon/castform-sunny.

Resolving the Bug

Anyone is open to making a PR for this issue.

[Skycoder42]

I think there are actual exceptions to that rule. For example, https://pokeapi.co/api/v2/pokemon/arceus has only a single pokemon resource, but multiple forms, one for each plate.

[SamuelAppleby]

I think there are actual exceptions to that rule. For example, https://pokeapi.co/api/v2/pokemon/arceus has only a single pokemon resource, but multiple forms, one for each plate.

Hmmmm, yes the arceus forms appear to be an error. I've confirmed with some of the major contributors about what dictates a form vs pokemon. Any mechanical change (stat, type, move etc.) necessitates a new pokemon resource, while a form is solely visual.

So, we need arceus entries rather than forms, which are not purely visual. Can you confirm @FallenDeity ? Thanks!