Skip to content

fix: encode the paybutton id used in its detail fetch #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Klakurka wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: encode the paybutton id used in its detail fetch #1136

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c152502
fix: encode the paybutton id used in its detail fetch
cursoragent Oct 1, 2026
d3ac4c0
Merge branch 'master' into cursor/fix-paybutton-fetch-url-2e84
Klakurka Oct 1, 2026
4450c04
Merge branch 'master' into cursor/fix-paybutton-fetch-url-2e84
Klakurka Oct 1, 2026
332330a
Potential fix for pull request finding 'Empty paybutton ID triggers a…
Klakurka Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pages/button/[id].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,13 @@ export const getServerSideProps: GetServerSideProps = async (context) => {

removeUnserializableFields(userProfile)

const routeId = context.params?.id
const paybuttonId = Array.isArray(routeId) ? routeId[0] ?? '' : routeId ?? ''

return {
props: {
userProfile,
paybuttonId: context.params?.id
paybuttonId
}
}
}
Expand Down Expand Up @@ -71,7 +74,8 @@ export default function PayButton (props: PaybuttonProps): React.ReactElement {
}

const fetchPaybutton = async (): Promise<PaybuttonWithAddresses> => {
const res = await fetch(`/api/paybutton/${props.paybuttonId}`, {
const paybuttonId = String(props.paybuttonId)
const res = await fetch(`/api/paybutton/${encodeURIComponent(paybuttonId)}`, {
method: 'GET'
})
let resData = await res.json() as PaybuttonWithAddresses | ResponseMessage
Expand Down
Loading