Conversation
rbev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligned Audit manifest discovery with the Error instance: each manifest is read and deserialized independently, so a malformed or unreadable file is logged with its path and does not prevent later persisters from loading. The existing outer catches still handle failures while enumerating manifest locations. Empty or invalid JSON is explicitly rejected rather than adding a null manifest.
Added Audit regression coverage for a legacy manifest without an assembly alongside later persisters, and for a malformed manifest followed by a valid persister. Tests call the shared loading method through an internal test assembly grant; public discovery APIs are unchanged.
Aligned the behavior of
SupportsMaintenanceModecontract: RavenDB advertises support, InMemory does not, and the Audit maintenance command rejects unsupported persisters before building settings or starting a host. Added a focused test for the InMemory rejection.Related PRs