Merge 1.2.0 alpha cycle into main

.claude/agents/code-quality.md

@@ -26,11 +26,11 @@ When invoked, you will:
 
 1. **Identify Changed Files**: Determine which files have been modified or created in the current work session.
 
-2. **Run Linter**: Execute `npm run lint` (Biome) on changed files. Capture all errors and warnings.
+2. **Run Linter**: Execute `pnpm run lint` (Biome) on changed files. Capture all errors and warnings.
 
-3. **Run Formatter**: Apply `npm run format:fix` to all changed files using project-configured Biome formatter.
+3. **Run Formatter**: Apply `pnpm run format:fix` to all changed files using project-configured Biome formatter.
 
-4. **Type Check**: Run `npm run type-check` (tsc --noEmit) to catch type errors.
+4. **Type Check**: Run `pnpm run type-check` (tsc --noEmit) to catch type errors.
 
 5. **Analyze Project Patterns**: Review code against established FlashForgeWebUI patterns (see checklist below).
 
@@ -144,7 +144,7 @@ Verify Biome configuration is respected:
 - **Semicolons**: As configured
 - **Line width**: Respect configured limit
 
-Run with `npm run lint` and `npm run format` to apply project settings.
+Run with `pnpm run lint` and `pnpm run format` to apply project settings.
 
 ## Behavioral Boundaries
 

.claude/agents/documenter.md

@@ -145,7 +145,7 @@ When processing multiple files:
 
 Always use this command to find files needing documentation:
 ```bash
-npm run docs:check
+pnpm run docs:check
 ```
 
 This checks all .ts, .tsx, .js, .jsx files in src/ for @fileoverview in the first 20 lines.

.claude/agents/primary-engineer.md

@@ -39,7 +39,7 @@ When invoked, you will:
    - Use EventEmitter with typed event maps
    - Follow existing backend structure for printer integrations
 
-5. **Verify and Refine**: Review your implementation for type safety, correctness, and adherence to patterns. Run `npm run type-check` and `npm run lint` to verify.
+5. **Verify and Refine**: Review your implementation for type safety, correctness, and adherence to patterns. Run `pnpm run type-check` and `pnpm run lint` to verify.
 
 ## Decision Framework
 

.github/workflows/ci.yml

@@ -0,0 +1,134 @@
+name: CI
+
+on:
+  push:
+    branches: [main, alpha]
+    paths-ignore:
+      - '**.md'
+      - 'LICENSE'
+      - '.gitignore'
+      - '.gitattributes'
+      - '.editorconfig'
+  pull_request:
+    branches: [main, alpha]
+    paths-ignore:
+      - '**.md'
+      - 'LICENSE'
+      - '.gitignore'
+      - '.gitattributes'
+      - '.editorconfig'
+  workflow_dispatch:
+    inputs:
+      emulator-ref:
+        description: 'flashforge-emulator-v2 git ref to run the E2E track against'
+        required: false
+        default: 'v0.3.0'
+        type: string
+
+concurrency:
+  group: ci-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  verify:
+    name: Type-check, lint, build, test
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    steps:
+      - name: Checkout FlashForgeWebUI
+        uses: actions/checkout@v4
+
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10.23.0
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: 'pnpm'
+
+
+      - name: Install dependencies
+        shell: bash
+        run: pnpm install --frozen-lockfile
+
+      - name: Type check
+        run: pnpm run type-check
+
+      - name: Lint
+        run: pnpm run lint
+
+      - name: Build (backend + webui)
+        run: pnpm run build
+
+      - name: Unit tests
+        run: pnpm test
+
+  e2e-emulator:
+    name: E2E (emulator + browser)
+    runs-on: ubuntu-latest
+    needs: verify
+    timeout-minutes: 40
+    steps:
+      - name: Checkout FlashForgeWebUI
+        uses: actions/checkout@v4
+
+      # The emulator lives in a separate public repo and provides the printers this
+      # track drives, so no real hardware is needed. Pinned to a release tag so an
+      # emulator change cannot silently break or silently change this CI; bump the
+      # tag (or dispatch with emulator-ref) to pick up a new emulator release.
+      - name: Checkout flashforge-emulator-v2
+        uses: actions/checkout@v4
+        with:
+          repository: GhostTypes/flashforge-emulator-v2
+          ref: ${{ inputs.emulator-ref || 'v0.4.0' }}
+          path: emulator
+
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10.23.0
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: 'pnpm'
+
+
+      - name: Install dependencies
+        shell: bash
+        run: pnpm install --frozen-lockfile
+
+      - name: Install emulator dependencies
+        working-directory: emulator
+        run: npm ci
+        env:
+          # Only the emulator's headless runtime is used here; skip the large
+          # Electron binary download this repo's e2e-tests track never launches.
+          ELECTRON_SKIP_BINARY_DOWNLOAD: '1'
+
+      # The browser track needs the chromium binary itself, not just its system libraries.
+      - name: Install Playwright chromium
+        run: pnpm exec playwright install --with-deps chromium
+
+      # Unlike FlashForgeUI-Electron's CI there is no xvfb-run and no chrome-sandbox
+      # fixup here: this track drives the plain Node server (dist/index.js) with
+      # headless Chromium, never a real Electron window.
+      - name: Run browser E2E against the emulator
+        run: pnpm run test:e2e
+        env:
+          FF_EMULATOR_ROOT: ${{ github.workspace }}/emulator
+
+      - name: Upload Playwright artifacts
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: playwright-e2e-artifacts
+          path: |
+            test-results/
+            playwright-report/
+          retention-days: 7
+          if-no-files-found: ignore

.github/workflows/e2e-tests.yml

@@ -63,11 +63,16 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10.23.0
+
       - name: Setup Node.js 20
         uses: actions/setup-node@v4
         with:
           node-version: 20
-          cache: 'npm'
+          cache: 'pnpm'
 
       - name: Cache pkg fetch
         uses: actions/cache@v4
@@ -77,19 +82,8 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-pkg-
 
-      - name: Configure GitHub Packages
-        shell: bash
-        run: |
-          echo "@ghosttypes:registry=https://npm.pkg.github.com" >> .npmrc
-          echo "@parallel-7:registry=https://npm.pkg.github.com" >> .npmrc
-          echo "//npm.pkg.github.com/:_authToken=${{ secrets.GITHUB_TOKEN }}" >> .npmrc
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
       - name: Install dependencies
-        run: npm ci
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: pnpm install --frozen-lockfile
 
       - name: Pre-download ARMv7 Node.js Binary
         if: matrix.arch == 'armv7'
@@ -102,15 +96,15 @@ jobs:
       - name: Build application
         shell: bash
         run: |
-          npm run build
+          pnpm run build
           if [[ "${{ matrix.platform }}" == "win" ]]; then
-            npx @yao-pkg/pkg . --targets node20-win-${{ matrix.arch }} --output dist/${{ matrix.output }}
+            pnpm exec pkg . --targets node20-win-${{ matrix.arch }} --output dist/${{ matrix.output }}
           elif [[ "${{ matrix.platform }}" == "mac" ]]; then
-            npx @yao-pkg/pkg . --targets node20-macos-${{ matrix.arch }} --output dist/${{ matrix.output }}
+            pnpm exec pkg . --targets node20-macos-${{ matrix.arch }} --output dist/${{ matrix.output }}
           elif [[ "${{ matrix.arch }}" == "armv7" ]]; then
-            npx @yao-pkg/pkg . --targets node20-linuxstatic-armv7 --output dist/${{ matrix.output }}
+            pnpm exec pkg . --targets node20-linuxstatic-armv7 --output dist/${{ matrix.output }}
           else
-            npx @yao-pkg/pkg . --targets node20-linux-${{ matrix.arch }} --output dist/${{ matrix.output }}
+            pnpm exec pkg . --targets node20-linux-${{ matrix.arch }} --output dist/${{ matrix.output }}
           fi
 
       - name: Verify binary size
@@ -130,6 +124,25 @@ jobs:
           fi
           echo "✓ Binary size: $size bytes"
 
+      # Write a deterministic config so the E2E auth assertions do not depend on the
+      # current DEFAULT_CONFIG values. Auth is explicitly enabled with the password
+      # the login step posts below ("changeme"). ConfigManager merges any omitted
+      # keys from DEFAULT_CONFIG at load time, so only auth-relevant keys are pinned.
+      - name: Write deterministic test config
+        if: matrix.can_execute == true
+        shell: bash
+        run: |
+          mkdir -p data
+          cat > data/config.json <<'EOF'
+          {
+            "WebUIEnabled": true,
+            "WebUIPort": 3000,
+            "WebUIPassword": "changeme",
+            "WebUIPasswordRequired": true
+          }
+          EOF
+          echo "✓ Wrote deterministic data/config.json"
+
       # Windows: use cmd wrapper to redirect output while keeping process detached
       - name: Start binary (Windows)
         if: matrix.can_execute == true && runner.os == 'Windows'
@@ -204,7 +217,7 @@ jobs:
           fi
 
           # Test index.html contains expected content
-          if ! curl -sf http://127.0.0.1:3000/ | grep -q "FlashForge Web UI"; then
+          if ! curl -sf http://127.0.0.1:3000/ | grep "FlashForge Web UI" > /dev/null; then
             echo "::error::GET / did not contain 'FlashForge Web UI'"
             curl -s http://127.0.0.1:3000/ | head -20
             exit 1
@@ -296,7 +309,7 @@ jobs:
         shell: bash
         run: |
           if [[ "${{ runner.os }}" == "Windows" ]]; then
-            if tasklist /FI "IMAGENAME eq ${{ matrix.output }}" 2>/dev/null | grep -q "${{ matrix.output }}"; then
+            if tasklist /FI "IMAGENAME eq ${{ matrix.output }}" 2>/dev/null | grep "${{ matrix.output }}" > /dev/null; then
               echo "::error::Binary left zombie processes"
               exit 1
             fi