Refactor acquisition services and refresh development guidance - #7
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acquisition service had grown into a single 1,310-line module mixing provider transport, release tokens and job lifecycle rules. Split these responsibilities into focused modules while retaining the existing
papyrus.services.acquisitionpublic imports and HTTP behavior.Replace broken setup-guide links with current runbooks and correct the configuration map. Add a deterministic OpenAPI exporter for the docs repository: it ignores local environment/configuration, excludes debug routes, and never starts the application lifespan. Normalize the five existing Ruff formatting violations so the standard quality gate passes.
Validation: full backend suite through the workspace test-database guard (341 passed, two external auth smoke tests excluded), Ruff lint/format and strict Mypy (145 source files). The export regression confirms identical output under contaminated environment variables and verifies
--check.No database schema, migrations, wire contracts or dependency changes. Docs CI will pin this published commit when checking its generated API snapshot. No provider-backed OAuth smoke tests were run.