Repository navigation
Add test ensuring $TMPDIR is honored by OpenSCAP - #2428
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Mab879
left a comment
Mab879
left a comment
There was a problem hiding this comment.
I know its test code, but let's fix some these automated finding from CodeQL for sure, but I think some the sonar findings are worth fixing as well.
|
Those CI fails look valid, but I'm not sure what is causing them to fail. |
|
The "Gating / Build, Test on Fedora Rawhide (NSS) (Container) (pull_request)" and testing-farm:fedora-rawhide-x86_64 fails can be reproduced separately and therefore aren't caused by this PR. I managed to reproduce them on testing farm machine with Rawhide on the current main branch. I reported it here: #2440 |
|
@Mab879 Do you have any idea what can we do with the D Security Rating on New Code ? |
From the site
So if you adjust the perms on the folder you create we might be able avoid this warning. |
This commit introduces a test that verifies that the TMPDIR environment variable is honored by OpenSCAP and that the TMPDIR environment variable is correctly used in OpenSCAP when it creates any temporary files during its execution. OpenSCAP shall use TMPDIR as base directory for temporary files, instead of forcing to use /tmp, which may be too small, depending on system's configuration. This is a regression test for: https://redhat.atlassian.net/browse/RHEL-222370 This test covers changes introduced by: OpenSCAP#2393
|
|
@Mab879 I have added a |
Based on the wording seems this one needs manual review. With the chmod we should be fine. Starting my review, hopefully will be done today. |
3 participants
This commit introduces a test that verifies that the TMPDIR environment variable is honored by OpenSCAP and that the TMPDIR environment variable is correctly used in OpenSCAP when it creates any temporary files during its execution. OpenSCAP shall use TMPDIR as base directory for temporary files, instead of forcing to use /tmp, which may be too small, depending on system's configuration.
This is a regression test for:
https://redhat.atlassian.net/browse/RHEL-222370
This test covers changes introduced by:
#2393