Repository navigation
Interface review: board of lamp rows, Export and Import, one Settings window (1.48.0) - #102
Conversation
… window (1.48.0) The interface review of brass 1.3.0 (brand), in the app and on the web page. Web page: the name with the version number, 'SPI NOR and NAND programmer'; a board of rows with a lamp each (ADAPTER, CHIP, STATE, DUMP, CAMEX) in place of the lamps and the display; eight buttons four a row with Export... (the dump shown) and Import... (a file to the dump folder as import-NAME.bin, not written). Write writes the dump shown. Web mode: POST /api/upload; POST /api/write with X-MicroSNANDer-File writes a dump already in the dump folder, no upload. Android app: the name with the version, the subtitle in plain type; the board (ADAPTER, CHIP, STATE, WEB with its address and a lock, CAMEX); nine buttons three a row with Export... (Save to a file, Share to an app), Import... and Settings; the Remote access panel is gone. One brass SETTINGS window: the app's section and CAMEX from the tunnel library, no link field. Start on boot and Show log with the log of events. A taken page port (8085) gives the next free one, shown, logged, and passed to the tunnel. Tests: tests/run.sh (websim: import, write of a dump, the page), gradle assembleDebug lintDebug assembleRelease, tests/android/remote-e2e.sh on API 34 and 21 (11 passed each); the port fallback and the tunnel to 8086 checked by hand on the emulator. Co-Authored-By: Claude <noreply@anthropic.com>
PR Summary by QodoUnify brass interfaces and add dump Import and Export
AI Description
Merge Risk
|
Code Review by Qodo
1.
|
…Save saves the dump named, Import never shows a half copy - web.c: an upload keeps the three newest imports and drops the older ones, so an open page cannot fill the disk however many uploads come (websim: four imports, three kept). - MainActivity.importName: '..' replaced until none is left (a...b.bin gave a name web.c refuses); isDump refuses '..' and '/' as dump_ok does. - Save to a file saves the dump the menu named, not whatever is the newest when the picker returns. - Import copies under .import-copy (a name no page takes) and renames it after the copy, so a remote Write never takes a half-copied file; the app keeps the three newest imports too. Co-Authored-By: Claude <noreply@anthropic.com>
|
Qodo review of bf49718: all four fixed in a7e44b2.
Local: |
Co-Authored-By: Claude <noreply@anthropic.com>
The interface review of the brass look (brass 1.3.0), in the Android app and on the web page, by the approved mock-ups.
Web page
import-NAME.bin, not written to the chip; it becomes the dump shown (link, hex view).Web mode (
src/web.c)POST /api/upload(X-MicroSNANDer-Name): the body into the dump folder; the name is reduced to letters, digits,.,-,_, never a path;-2,-3for the same name; one at a time, not while an operation runs.POST /api/writewith no body andX-MicroSNANDer-File: <dump>writes that dump of the dump folder (a regular file, no link, a dump name only); the chip still has to be confirmed.Android app
Version 1.48.0 (MINOR), CHANGELOG, README in three languages, new screenshots of the web page and the main screen.
Tests (local, in Docker)
tests/run.sh: all passed; websim covers the upload (names, a path, the same name, no file, busy) and the write of a dump (no upload, 404 for a missing or path name, 400 without the chip confirmed), and the page.gradle assembleDebug lintDebug assembleRelease: OK;ownsListenerkept in the release dex.tests/android/remote-e2e.sh: API 34 and API 21, 11 passed each.🤖 Generated with Claude Code