Repository navigation
Android app: camex 4.1.2, the tunnel takes connections only to the app's own page (1.47.6) - #101
Merged
Merged
Conversation
…p's own page (1.47.6) bundles/camex on camex 4.1.2 (53c3dd8): a new TCP connection from the tunnel passes only to web_port and only when the app's own socket listens there; any other gets a reset. The app already gives the library its page's port as web_port. The release build keeps CamexVpnService.ownsListener() (camex's consumer-rules.pro), checked in its dex. Tests: tests/run.sh, assembleDebug lintDebug assembleRelease, tests/android/remote-e2e.sh on API 34 and 21 (11 passed each). Co-Authored-By: Claude <noreply@anthropic.com>
PR Summary by QodoRestrict Android tunnel connections to the app’s own web page
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
bundles/camexto camex 4.1.2 (OpenIPC/camex#187): a new TCP connection from the tunnel reaches onlyweb_port, and only when the app's own socket listens there; anything else gets a TCP reset. With several apps that embed camex on one device, one app's tunnel could otherwise serve another app's page on the same port.The app already passes its page's port (8085 by default) as
web_port, so no app change is needed. The release build (R8) keepsCamexVpnService.ownsListener()through camex'sconsumer-rules.pro; checked in the release dex.Version 1.47.6, CHANGELOG entry.
Tests, local in Docker:
tests/run.sh: all passed;makewithout warningsgradle assembleDebug lintDebug assembleRelease: OKtests/android/remote-e2e.sh(the page through a camex tunnel): API 34 (getConnectionOwnerUid) 11 passed, API 21 (/proc/net/tcp) 11 passed🤖 Generated with Claude Code