Repository navigation
Read RecordKey and DisclosureKey, the bases RootKey and AnonymousKey became - #1738
Merged
Merged
Conversation
…became agent-comms 530a4708 redirected the name-only subclasses RootKey onto RecordKey and AnonymousKey onto DisclosureKey. Toad still imported both, so agent-comms main 88e245f7's install refused at toad/screens/team.py:12 with "cannot import name 'RootKey'". The three readers now name the bases: screens/team.py (TeamDetails.read_detail), widgets/declared_table.py (TableSelection.key) and tests/textual/test_team_page.py. Equality is unchanged: RecordKey(X) == RecordKey(X), and each DisclosureKey() is distinct by identity, as AnonymousKey was. Applied with NRA patch_target ops; toad.screens.team, toad.widgets.declared_table and toad.app import against agent-comms 88e245f7's source. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dRFPZCCoQqYN2vmHCG
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read RecordKey and DisclosureKey, the bases RootKey and AnonymousKey became
agent-comms 530a4708 redirected the name-only subclasses RootKey onto
RecordKey and AnonymousKey onto DisclosureKey. Toad still imported both, so
agent-comms main 88e245f7's install refused at toad/screens/team.py:12 with
"cannot import name 'RootKey'".
The three readers now name the bases: screens/team.py (TeamDetails.read_detail),
widgets/declared_table.py (TableSelection.key) and tests/textual/test_team_page.py.
Equality is unchanged: RecordKey(X) == RecordKey(X), and each DisclosureKey()
is distinct by identity, as AnonymousKey was. Applied with NRA patch_target ops;
toad.screens.team, toad.widgets.declared_table and toad.app import against
agent-comms 88e245f7's source.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dRFPZCCoQqYN2vmHCG