Repository navigation
Keep live error notes in chronological order - #1737
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at dbafc12 blocks on 6 lines: Warn-only, never blocks (11) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1452. One inherited posting capability replaces the error box riding a fixed live-tail rank. ErrorNote inherits ChronologicalEntry; it captures the already-received cursor before mounting. The transcript owner keeps the earlier saved range before the note and puts subsequent saved rows after it using the existing pager and viewport-preservation path. No fake Pi row, Core cursor field, second reader or error-specific scroll callback. Saved range claims now keep the active publisher alive when an earlier range reports coverage. Reopening an evicted view restores the whole canonical source, not just the last range. Proof: 23 focused app checks passed in 25.81s, including the new chronological, off-tail-scroll and eviction/return case; source-owner guard closing behind this checkpoint. Reader-crash hotfix is separate PR 1736 (already merged). Installed/user verification follows the paired install. Known separate red encountered: the existing wire queue test asserts holds_input at test_input_failure_draft.py:147; not offered as green evidence.