[trissim]

Toad's tests wait for real receipts, so they pass under a pilot that settles instead of sleeping (OpenHCSDev/textual#257). One product fix rides along: a stale read acknowledgement no longer re-requests work on a suspended source or warns the user.

textual#257 replaces the pilot's 20 ms CPU-time sleeps with a settle on owed work: Textual's suite 40 s → 26.5 s; Toad's keypress-heavy files, serial on one worker, 135.9 s → ~88 s. Under it, 15 Toad tests failed deterministically; each was passing on main only because a sleep happened to cover work no message queue owes. Every fix waits on the owner's receipt for that work; where the receipt was missing or written out by hand, the owner now declares it.

Merge order: textual#257 first (it adds Button.accepts_press, used here), then this PR with the relock.

Receipts the owners now declare

• StyledRows.rows_ready: a block's rows come from the render processes (styled_rows.py:82). A press landed on AboveThrobber because the response body was still 0 rows tall (test_hover_during_drag). Seven test waits that read _render_worker and _styled from outside now ask the widget.
• Button.accepts_press (Textual): a Button refuses a press during the previous press's 0.2 s effect. The ACP log test pressed Wrap and Latest twice inside it; one press helper waits on the receipt and replaces the hand-written -active wait.
• TextualUi.clickable / until_clickable: a click lands on what the published frame shows; the palette's input was clicked before its pushed screen had a frame. One test wrote the check out by hand; textual_steps.command_dialog, a third copy with no caller, is deleted.
• TextualUi.until_delivery_shown: a sent message's delivery status arrives from Core after its rows and lifts the bottom-anchored page two rows. Two tests pressed a link and released on the status's details link (existing_thread_link, clipboard image).

Waits for the effect the test claims

• welcome_view: the opened thread's tab is selected (the label mounts first), as test_goal_owner_views already waited.
• channel_any_mode: the bus records the toggle (the verb runs in Core, off the UI loop).
• message_notifications: the page measures again once the taller rows land.
• saved_view_read_only: the chat mounts, then the read-only decision sets status and composer together.
• tab_scrollbar_top: the underline's slide runs on Toad's effect clock, which wait_for_scheduled_animations never covered; early in a slide from off-strip nothing is highlighted. strip_settled waits on effect_phase(TAB_SLIDE).in_motion.

Product fixes the settle exposed

• Tab history (test_navigation_keys). The workspace selects a tab early in a switch and recorded the visit only after its later frames, so H then L inside that window counted from the old cursor and landed on the wrong tab (a quick H L does it to a person). TabOrder.navigate moves the cursor when the step is taken; the app's select_session records a visit and show_history_step does not (the step already did), so history_index, threaded through the switch only to re-record it, is deleted and record_visit only appends.
• Paging on an unbound tab. Uncaptured.read_page raised ValueError("Transcript paging requires a bound thread"), reported as an app error whenever a latest-page request queued before an unbind ran after it. It raises ReadAgain, which execute() already drops.
• A rewritten session file (transcript_presentation_fencing). When a commit's draw could not publish, its PreparedReplacementViewportRequest was deferred like a reader's request and later drew the commit's rows alone, with nothing recording the painted cursor: the screen showed the new file while reads acknowledged the old one, failed twice and warned "Saved history reloading". A commit's page no longer defers; the commit keeps its demand and retries.

Stale read acknowledgements

TranscriptSource.mark_read runs in the screen's painted-read worker, which suspend() does not join. An ack in flight across retire, close or detach that met a replaced file retried, failed again, called require_commit() on the suspended source and showed "Saved history reloading". The ack now captures generation (the owner of "in-flight view work revoked") and, if the work was revoked while it ran, leaves the read to the work that replaced it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

[github-actions]

debt-src at cb2fe5e blocks on 3 lines:

grew BannedVocabulary:src/toad/widgets/styled_rows.py +1
found BannedVocabulary:src/toad/widgets/styled_rows.py at src/toad/widgets/styled_rows.py:56
introduced BannedVocabulary:src/toad/widgets/styled_rows.py at lines [56]