Repository navigation
A send right after a view refreshes its page reader is not refused as a changed route - #1612
Merged
Merged
Conversation
… a changed route ChannelDestination.shown asked whether the view still held the very page-reader object the send was built on. A DM view replaces its reader after it opens (and on every refresh), so a message sent in that window was refused as "Message route changed; reopen this view" and dumped back into the composer, appended to whatever the user had typed since. The question is whether the view still shows this conversation from this root (IDEN-7: the identity check was wider than that). - ReplaceablePageSource.reads_from(root): a closed history reads none; WirePageBuffer reads from its loader's root. - ChannelDestination keeps the root and the conversation, drops the reader it held, and asks the view's current reader. Found by the exact pilot settle (OpenHCSDev/textual#257): the old 20 ms sleep let the reader swap land before the test's send. test_input_failure_draft 8/8 and test_stale_route_writes pass on Textual main and on the settle build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A DM sent right after the view opens (or refreshes) was refused as "Message route changed; reopen this view" and pasted back into the composer, appended to the user's other draft.
ChannelDestination.showncompared the page-reader object; the view replaces that reader on open and on refresh. It now asks whether the view still shows this conversation from this root (ReplaceablePageSource.reads_from; a closed history reads none).Evidence:
test_input_failure_draft8/8 (3 were failing under the exact pilot settle, OpenHCSDev/textual#257) andtest_stale_route_writes(a conversation the view no longer shows is still refused) pass on Textual main and on the settle build.🤖 Generated with Claude Code
https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd