Repository navigation
Keymap discovery runs its fresh-interpreter case in a new interpreter - #1593
Merged
Merged
Conversation
toad#1592 made the app test template import every toad module before it forks, so the forked child this case ran in already held toad.screens.welcome and its first assertion failed before discovery ran. The case is about an interpreter that never imported the screen, so it now runs in one: a new interpreter with this case's roots, asserting the same discovery facts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
The check was a python -c string, so a rename of KeymapCatalog.capture would miss it and no linter or type checker read it; it is now tests/support/keymap_discovery.py. The path insert restated the editable install the test environment already provides, and is deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd
trissim
enabled auto-merge
November 6, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from toad#1592 (mine). The app test template now imports every toad module before it forks. That means the forked child
test_unopened_screen_invocations_are_discovered_in_a_fresh_processruns in already holdstoad.screens.welcome, so its first assertion (tests/textual/test_keymap_discovery.py:11) failed before discovery ran. The fulltests/textualrun on 8 workers after #1592 shows it as the one new red.Fix: the case is about an interpreter that has never imported the screen, so it now starts one. It's a new
sys.executablewith this case'sworkspaceroots, and it asserts the same four facts: welcome isn't imported, capture imports it,NewSessionAction's title matches, and its defaults match.tests/textual/test_keymap_discovery.py: 1 passed (10.1 s, including the template's one-time warm-up).🤖 Generated with Claude Code
https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd