Repository navigation
The pilot waits only on pumps that owe work; the queue is the pump's and says so - #252
Merged
Merged
Conversation
…and says so Pilot._wait_for_screen posted a Callback to the app and every widget on the screen after each pause, press and click, then waited for all of them. Waking an idle widget is not free: it dispatches the Callback and then runs a full Idle pass. Across Toad's suite profile that was 757,738 posts from _wait_for_screen and 588,863 _on_idle passes, almost all on widgets with nothing queued. - The message queue carries its activity: Owing after a put, Settled when its pump asks for a message and finds none (everything before is handled, idle work included). A refresh already enqueues Prompt through check_idle, so outstanding work always shows as a put. - MessagePump.call_after_pending asks that activity: Owing schedules the callback behind the work, Settled answers False. _wait_for_screen keeps its shape and calls it. - Queue moves into message_pump.py and _queue.py is deleted: it existed only to run pumps, and the split was what would have needed an import cycle once its state had pump behaviour. Toad's eight heaviest test files (FamilyMeta agent_comms, same Toad): 82.7 s -> 63.6 s wall, same three pre-existing channel-tab failures. Textual queue/pilot/pump/on/screens: 195 passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pilot._wait_for_screen woke the app and every widget on screen after each pause/press/click: 757,738 posts and 588,863 Idle passes across Toad's suite, almost all on widgets with nothing queued.
The queue now carries its activity (Owing after a put, Settled when its pump asks and finds none);
MessagePump.call_after_pendingasks it, and the pilot calls that instead ofcall_later.Queuemoves into message_pump.py and_queue.pyis deleted: it existed only to run pumps.🤖 Generated with Claude Code
https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd