Repository navigation
Hotfix: missed .running consumers + stale test attributes - #4599
Merged
Merged
Conversation
PR #4594 deleted ThreadStatus.running ClassVar but missed 5 product consumers and 3 test consumers. The install's TeamHeartbeat crashed with AttributeError on ArchivedThreadStatus, and Toad crashed on open. Add is_running() method override: base returns False, RunningThreadStatus returns True. Migrate all 5 product consumers and 3 test consumers. Same grep lesson as .recorded (#4596): grep -n catches 400 unrelated .running hits and the eye scans past the real ones. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dRFPZCCoQqYN2vmHCG
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_running()method override on ThreadStatus (base False, RunningThreadStatus True).runningClassVar.running,.working,.ready— all deleted ClassVars with stale test consumersToad crashes on open because TeamHeartbeat reads
.runningon ArchivedThreadStatus.Same grep-miss pattern as .recorded (#4596): the PR that deletes a ClassVar greps for consumers but the attribute name matches too many unrelated things.
Files changed
is_running()base + override.running->.is_running()Test plan
Generated with Claude Code
https://claude.ai/code/session_01RnH6dRFPZCCoQqYN2vmHCG