Repository navigation
Fix audit downloads and source hashes in standalone dashboards - #19
Merged
Merged
Conversation
|
Preview closed This PR is closed and its preview has been removed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard's source audit, language-assignment, and analysis links return 404 on Pages because publishing includes only the standalone HTML pages and licenses. The source caption also displays an empty SHA-256 when a build contains multiple CSVs.
Download these files from the original payload embedded in the page, preserving the build-snapshot meaning of the existing artifacts. Show each source CSV with its own SHA-256 and disable CSV downloads for empty builds. The downloads work in standalone local HTML, production, the demo, and PR previews without publishing companion data files.
Browser regressions cover empty builds, one and multiple source files, previews containing only HTML, valid JSON/CSV contents and filenames, quoted/multiline CSV metadata, and preserving the build snapshot after temporary uploads.
python3 -m tests.checkpasses, including both scoring engines and Chrome.