Skip to content

OpenConceptLab/ocl_issues#2987 | owner level concepts search - #91

Merged
snyaggarwal merged 2 commits into
mainfrom
issues#2987
Nov 2, 2026
Merged

snyaggarwal merged 2 commits into
mainfrom
issues#2987

Conversation

@snyaggarwal

Copy link
Copy Markdown
Contributor

Linked Issue

Closes OpenConceptLab/ocl_issues#2987

@snyaggarwal
snyaggarwal requested a review from paynejd November 2, 2026 11:22
@snyaggarwal snyaggarwal self-assigned this Nov 2, 2026

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: changes requested

Issue complete: no — the owner-scoped results are lost when switching resource type, so the scope does not carry from Concepts to Mappings as required.

Security blockers: none.

Verification: 112 tests passed; changed-file ESLint passed; development build passed; git diff --check passed. The new Searchlight paths do not have focused regression coverage.

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: changes requested

Issue complete: no — the prior owner-filter loss is fixed for the resource tabs that exist, but the acceptance criterion’s Mappings transition is still not reachable in the UI.

Findings: 1 P1; no P2–P5 findings; no separate nits.

Security blockers: none. The open/private boundary is respected.

Verification: 115 tests passed; changed-file ESLint passed; development build passed; git diff --check passed; GitHub CI and Snyk passed.

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected re-review: no findings.

I retracted the two earlier inline comments. They misread the ticket’s illustrative Mappings example as requiring a global Mappings control, but that control does not exist in the current product surfaces. The relevant supported transition is among the existing global-search tabs; the owner filters are preserved when switching to Repositories. Org/user namespace search exposes neither Concepts nor Mappings, so those transitions are not applicable there.

Issue complete: yes.

P1–P5 findings: none. Nits: none. Security blockers: none. The open/private boundary is respected.

Verification: 115 tests passed; changed-file ESLint passed; development build passed; git diff --check passed; GitHub CI and Snyk passed.

@snyaggarwal
snyaggarwal merged commit f7c74ae into main Nov 2, 2026
2 checks passed
@snyaggarwal
snyaggarwal deleted the issues#2987 branch November 2, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Searchlight: search concepts across the current org

1 participant