Skip to content

DO NOT MERGE (on hold until Nov 2) · OpenConceptLab/ocl_online#236 | Repo URLs from app.v2.<env> resolve to that environment's API - #90

Merged
snyaggarwal merged 1 commit into
mainfrom
ocl_online/236-app-v2-host
Nov 3, 2026
Merged

snyaggarwal merged 1 commit into
mainfrom
ocl_online/236-app-v2-host

Conversation

@paynejd

@paynejd paynejd commented Nov 1, 2026

Copy link
Copy Markdown
Member

Caution

Do not merge. This PR is on hold until the team agrees on it on Mon Nov 2, 2026. Nothing here deploys before then.

Part of OpenConceptLab/ocl_online#236: TBv2 is also served at app.v2.<env>.openconceptlab.org, ahead of TBv3 becoming the default at app.<env>. app.<env> keeps serving TBv2.

What changes

toAPIOrigin turns a Term Browser origin into its environment's API origin. TBv3 uses it to fetch a repo from a pasted OCL URL, and to tell this server's repos from another server's. It mapped app.<env> and app.v3.<env> to api.<env>, but app.v2.<env> became api.v2.<env>, which doesn't exist. So an app.v2 repo URL counted as another server and its fetch failed.

  • src/common/appUrls.js: toAPIOrigin moves here, next to resolveMapperURL, and also maps app.v2.<env> to api.<env>. Results for app. and app.v3. origins don't change.
  • src/common/utils.js: re-exports it, so components/repos/utils.js imports it as before.
  • src/common/__tests__/appUrls.test.js: covers app, app.v2 and app.v3 hosts, plus an origin that's already an API origin.

The other items #236 lists for TBv3 need nothing here: getEnv already handles app.<env> and app.v3.<env> (OpenConceptLab/ocl_issues#2848), and TBv3 has no link to TBv2 yet.

Testing

  • npm test: 113 pass.
  • CI's ESLint command: clean.

🤖 Generated with Claude Code

…o that environment's API

toAPIOrigin moves to common/appUrls.js, next to resolveMapperURL, and maps
app.v2.<env> to api.<env> as it already did app.<env> and app.v3.<env>.
Before, an app.v2 repo URL resolved to api.v2.<env>, which doesn't exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@paynejd

paynejd commented Nov 1, 2026

Copy link
Copy Markdown
Member Author

Codex review, pass 1 (codex-cli 0.166.0, commit 4ee9f96)

Verdict: clean. No findings, so no further passes are needed.

findings.json
{
  "reviewer": "codex-cli 0.166.0",
  "perspective": "defects",
  "mode": "full",
  "commit": "4ee9f96e0ea19399f5adb9ee068fd3a01106f7fa",
  "verdict": "clean",
  "prior": [],
  "findings": []
}

@paynejd

paynejd commented Nov 1, 2026

Copy link
Copy Markdown
Member Author

Simplification review (claude subagent, commit 4ee9f96)

Verdict: clean. Nothing to cut. Review loop done: Codex pass 1 clean, no commits since it.

simplify.json
{
  "reviewer": "claude subagent",
  "perspective": "simplify",
  "mode": "full",
  "commit": "4ee9f96e0ea19399f5adb9ee068fd3a01106f7fa",
  "verdict": "clean",
  "prior": [],
  "findings": []
}

@snyaggarwal
snyaggarwal marked this pull request as ready for review November 3, 2026 02:20
@snyaggarwal
snyaggarwal merged commit 8fc9f4c into main Nov 3, 2026
2 checks passed
@snyaggarwal
snyaggarwal deleted the ocl_online/236-app-v2-host branch November 3, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants