Repository navigation
DO NOT MERGE (on hold until Nov 2) · OpenConceptLab/ocl_online#236 | Repo URLs from app.v2.<env> resolve to that environment's API - #90
Merged
Conversation
…o that environment's API toAPIOrigin moves to common/appUrls.js, next to resolveMapperURL, and maps app.v2.<env> to api.<env> as it already did app.<env> and app.v3.<env>. Before, an app.v2 repo URL resolved to api.v2.<env>, which doesn't exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Codex review, pass 1 (codex-cli 0.166.0, commit 4ee9f96) Verdict: clean. No findings, so no further passes are needed. findings.json{
"reviewer": "codex-cli 0.166.0",
"perspective": "defects",
"mode": "full",
"commit": "4ee9f96e0ea19399f5adb9ee068fd3a01106f7fa",
"verdict": "clean",
"prior": [],
"findings": []
} |
Member
Author
|
Simplification review (claude subagent, commit 4ee9f96) Verdict: clean. Nothing to cut. Review loop done: Codex pass 1 clean, no commits since it. simplify.json{
"reviewer": "claude subagent",
"perspective": "simplify",
"mode": "full",
"commit": "4ee9f96e0ea19399f5adb9ee068fd3a01106f7fa",
"verdict": "clean",
"prior": [],
"findings": []
} |
snyaggarwal
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge. This PR is on hold until the team agrees on it on Mon Nov 2, 2026. Nothing here deploys before then.
Part of OpenConceptLab/ocl_online#236: TBv2 is also served at
app.v2.<env>.openconceptlab.org, ahead of TBv3 becoming the default atapp.<env>.app.<env>keeps serving TBv2.What changes
toAPIOriginturns a Term Browser origin into its environment's API origin. TBv3 uses it to fetch a repo from a pasted OCL URL, and to tell this server's repos from another server's. It mappedapp.<env>andapp.v3.<env>toapi.<env>, butapp.v2.<env>becameapi.v2.<env>, which doesn't exist. So anapp.v2repo URL counted as another server and its fetch failed.src/common/appUrls.js:toAPIOriginmoves here, next toresolveMapperURL, and also mapsapp.v2.<env>toapi.<env>. Results forapp.andapp.v3.origins don't change.src/common/utils.js: re-exports it, socomponents/repos/utils.jsimports it as before.src/common/__tests__/appUrls.test.js: coversapp,app.v2andapp.v3hosts, plus an origin that's already an API origin.The other items #236 lists for TBv3 need nothing here:
getEnvalready handlesapp.<env>andapp.v3.<env>(OpenConceptLab/ocl_issues#2848), and TBv3 has no link to TBv2 yet.Testing
npm test: 113 pass.🤖 Generated with Claude Code