[snyaggarwal]

Part of OpenConceptLab/ocl_online#418, following the design revision on the ticket.

• Removes the TBv2 button
• Adds Mapping project to the + menu (after Repository, before Bulk import)
• Tray: My Mapping Projects opens the new map-projects profile tab; the Create link beside My Organizations now works
• User and org profiles get a Mapping Projects tab, plus a ProfileTabs slot for the private package
• MAPPER_URL config; unset on a non-openconceptlab.org host hides the Mapper items

Sibling PRs: OpenConceptLab/oclmap#122, https://github.com/OpenConceptLab/ocl-community-site/pull/213

🤖 Generated with Claude Code

[snyaggarwal]

Updated review after Jon's revised unified-navigation design on OpenConceptLab/ocl_online#418.

Correction: I withdraw the earlier app-switcher/one-click finding. Sending My Mapping Projects to the TermBrowser profile tab, naming work rather than apps, and omitting a direct Community item are intentional in the revised design.

Remaining findings — request changes:

1. MapProjects.jsx:23-31 fetches only /:ownerType/:owner/map-projects/. For a user, the current Mapper list also fetches /users/:user/orgs/map-projects/; without that second request, My Mapping Projects drops projects owned by the user's organizations. The revised design explicitly identifies both endpoints as the data behind the new profile tab.
2. The revised tray requires repository and mapping-project counts. LeftMenu.jsx:97-105 renders the repository count but no Mapping Projects count (it renders only the existing waitlist chip), so the two trays do not yet match the approved mock.
3. Please add regression coverage for the combined user + organization project list, the Mapping Projects count, and configured/official/unconfigured Mapper URL behavior. The graph currently finds no tests for getMapperURL, trayItems, useProfileTabs, or MapProjects.

The corrected cross-repo review is on OpenConceptLab/ocl_online#418.

[snyaggarwal]

Addressed the review in 53657dc: the Mapping Projects tab now lists user and organization projects (deduplicated), the tray shows the Mapping Projects count, the tray highlights Mapping Projects on nested paths, and tests cover Mapper URL resolution (configured, official host, localhost, custom host), project merging, counts and tray items. An unconfigured custom host resolves to the production Mapper, as intended.

[snyaggarwal]

Final review — DO NOT MERGE (53657dc)

The follow-up commit resolves the earlier project-list, count, selection and test-coverage findings. CI is green, and the local suite passes (83 tests plus ESLint).

One release blocker remains: resolveMapperURL() deliberately returns https://map.openconceptlab.org for localhost, an unconfigured custom host, or a missing origin. That makes hasMapper() true everywhere, so an ordinary custom/self-hosted TermBrowser advertises Mapping Projects and can send its local project paths to the production Mapper.

Jon's revised design says the opposite: when the Mapper URL is set, the integrated items show; when it is unset, TermBrowser runs alone and hides them. Only a recognized openconceptlab.org app host gets the temporary hostname fallback. This is also required by the open-core rule that optional hosted connections are off until configured.

Change the unrecognized/unconfigured fallback to no Mapper (''), keep the configured and recognized-official-host behavior, and update the tests that currently enshrine the production fallback. With that change and green checks, I recommend merge.

[snyaggarwal]

Addressed the final review in e10a4e5: the Mapper URL now resolves only from configuration or a recognized openconceptlab.org app host; otherwise there is no Mapper and the Mapper-dependent items stay hidden. Tests updated.

[snyaggarwal]

Final review — round 2

Recommendation: MERGE once the PR is marked ready.

Reviewed head e10a4e5 against the revised unified-tray design. The prior blocker is resolved: an unconfigured custom/self-hosted Term Browser no longer invents a production Mapper connection, while configured and recognized OCL deployments retain the intended integration.

Validation:

• Local test suite: 83/83 passed
• ESLint: passed
• GitHub PR checks and Snyk: passed

No remaining blocking findings in this PR.

(Final review round 2)

[paynejd]

Codex review, pass 1 (codex-cli 0.166.0, commit 7e8f964)

Verdict: findings: 1 P1, 1 P2.

• F1.1 (P1) src/components/map-projects/MapProjects.jsx:27: Failed page requests silently produce an apparently complete empty or partial project list. Response: Fixed in d2d2740: fetchAllPages (now in src/common/mapProjects.js) rejects when any page fails, and the tab shows "Could not load mapping projects." with Try again. Unit tests added. A failed count request still reads 0; recorded as P3.
• F1.2 (P2) src/components/map-projects/MapProjects.jsx:28: The 20-page cutoff violates A3's requirement to load every page. Response: Accepted, not fixed: the cap is 2,000 projects per owner list, far above any owner today.

findings.json

{
 "reviewer": "codex-cli 0.166.0",
 "perspective": "defects",
 "mode": "full",
 "commit": "7e8f964e471731102ec0c93654ae4dabba932756",
 "verdict": "findings",
 "prior": [],
 "findings": [
  {
   "id": "F1.1",
   "severity": "P1",
   "tag": null,
   "file": "src/components/map-projects/MapProjects.jsx",
   "line": 27,
   "claim": "Failed page requests silently produce an apparently complete empty or partial project list.",
   "scenario": "An owner has 150 projects and page 2 returns HTTP 500. APIService resolves failures rather than rejecting, so this code treats the response as an empty final page and displays only the first 100 projects. Searching for a project on page 2 falsely reports no results. A first-page failure instead displays 'No mapping projects yet.'",
   "action": "Validate each response before accepting its data. Surface a loading failure or incomplete-list state with retry instead of presenting failed requests as successful empty pages; apply equivalent validation to project counts.",
   "lines_delta": null,
   "confidence": "high"
  },
  {
   "id": "F1.2",
   "severity": "P2",
   "tag": null,
   "file": "src/components/map-projects/MapProjects.jsx",
   "line": 28,
   "claim": "The 20-page cutoff violates A3's requirement to load every page.",
   "scenario": "A user or organization endpoint contains 2,001 projects. Loading stops after 2,000 despite the API returning a next-page header. The remaining project cannot appear in the list or its client-side search, and there is no pagination control to reach it.",
   "action": "Continue until the API has no next page. If a protective cutoff is necessary, expose an explicit continuation mechanism and avoid presenting truncated search results as complete.",
   "lines_delta": null,
   "confidence": "high"
  }
 ]
}

Codex review, pass 2 (codex-cli 0.166.0, commit dbcfeda)

Verdict: clean. F1.1 resolved; F1.2 stands as accepted. Also reviewed: dbcfeda (docker-compose's MAPPER_URL default is now empty) and COMMUNITY_SITE_URL's move in constants.js.

findings.json

{
 "reviewer": "codex-cli 0.166.0",
 "perspective": "defects",
 "mode": "verify",
 "commit": "dbcfedaaa26d5e6d0a70d72038d6eba32af06a6e",
 "verdict": "clean",
 "prior": [
  {
   "id": "F1.1",
   "status": "resolved"
  },
  {
   "id": "F1.2",
   "status": "unresolved"
  }
 ],
 "findings": []
}

[paynejd]

Simplification review (Claude subagent, commit dbcfeda)

9 suggestions. Applied in 8aa83e3: S1 and S2 (mergeProjects is a flat dedupe; its non-list guard and test go) and S4 (the count hook builds its requests like the tab does). Declined for today's deploy:

• S3 (drop the plugin-tab promise cache): it touches the plugin loader; not needed for this change.
• S5 (shared tray sx constants): it restyles the main tray render; follow-up.
• S6 (one shared summary-count component): it touches two files; follow-up.
• S7 (shared message row): two rows; no clearer.
• S8 and S9 (navigation test and file): these must stay byte-identical across oclweb3, oclmap and ocl-community-site.

Codex check of commits dbcfeda..8aa83e3 (codex-cli 0.166.0)

Verdict: clean.

findings.json

{"reviewer":"codex-cli 0.166.0","perspective":"defects","mode":"final","commit":"8aa83e3b42e79e5ca5f6b93205d85a10faeafca0","verdict":"clean","prior":[],"findings":[]}

[paynejd]

Approved after the takeover review: Codex clean (2 passes + final check), simplification review applied, CI green. OpenConceptLab/ocl_online#418